Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ARM: 8404/1: dma-mapping: fix off-by-one error in bitmap size check

nr_bitmaps member of mapping structure stores the number of already
allocated bitmaps and it is interpreted as loop iterator (it starts from
0 not from 1), so a comparison against number of possible bitmap
extensions should include this fact. This patch fixes this by changing
the extension failure condition. This issue has been introduced by
commit 4d852ef8c2544ce21ae41414099a7504c61164a0 ("arm: dma-mapping: Add
support to extend DMA IOMMU mappings").

Reported-by: Hyungwon Hwang <human.hwang@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Hyungwon Hwang <human.hwang@samsung.com>
Cc: stable@vger.kernel.org # v3.15+
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

authored by

Marek Szyprowski and committed by
Russell King
462859aa 8e0c34b0

+1 -1
+1 -1
arch/arm/mm/dma-mapping.c
··· 1971 1971 { 1972 1972 int next_bitmap; 1973 1973 1974 - if (mapping->nr_bitmaps > mapping->extensions) 1974 + if (mapping->nr_bitmaps >= mapping->extensions) 1975 1975 return -EINVAL; 1976 1976 1977 1977 next_bitmap = mapping->nr_bitmaps;