Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

x86/irq, ACPI: Remove private function mp_register_gsi()/ mp_unregister_gsi()

Function mp_register_gsi() is only called once, so fold it into caller
acpi_register_gsi_ioapic(). Do the same for mp_unregister_gsi().

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Tested-by: Joerg Roedel <jroedel@suse.de>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: David Cohen <david.a.cohen@linux.intel.com>
Cc: Sander Eikelenboom <linux@eikelenboom.it>
Cc: David Vrabel <david.vrabel@citrix.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dimitri Sivanich <sivanich@sgi.com>
Cc: Len Brown <len.brown@intel.com>
Cc: Pavel Machek <pavel@ucw.cz>
Link: http://lkml.kernel.org/r/1428978610-28986-29-git-send-email-jiang.liu@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

authored by

Jiang Liu and committed by
Thomas Gleixner
46176f39 4399b14f

+18 -39
+18 -39
arch/x86/kernel/acpi/boot.c
··· 400 400 return 0; 401 401 } 402 402 403 - static int mp_register_gsi(struct device *dev, u32 gsi, int trigger, 404 - int polarity) 405 - { 406 - int irq, node; 407 - struct irq_alloc_info info; 408 - 409 - if (acpi_irq_model != ACPI_IRQ_MODEL_IOAPIC) 410 - return gsi; 411 - 412 - trigger = trigger == ACPI_EDGE_SENSITIVE ? 0 : 1; 413 - polarity = polarity == ACPI_ACTIVE_HIGH ? 0 : 1; 414 - node = dev ? dev_to_node(dev) : NUMA_NO_NODE; 415 - ioapic_set_alloc_attr(&info, node, trigger, polarity); 416 - irq = mp_map_gsi_to_irq(gsi, IOAPIC_MAP_ALLOC, &info); 417 - if (irq < 0) 418 - return irq; 419 - 420 - /* Don't set up the ACPI SCI because it's already set up */ 421 - if (enable_update_mptable && acpi_gbl_FADT.sci_interrupt != gsi) 422 - mp_config_acpi_gsi(dev, gsi, trigger, polarity); 423 - 424 - return irq; 425 - } 426 - 427 - static void mp_unregister_gsi(u32 gsi) 428 - { 429 - int irq; 430 - 431 - if (acpi_irq_model != ACPI_IRQ_MODEL_IOAPIC) 432 - return; 433 - 434 - irq = mp_map_gsi_to_irq(gsi, 0, NULL); 435 - if (irq > 0) 436 - mp_unmap_irq(irq); 437 - } 438 - 439 403 static struct irq_domain_ops acpi_irqdomain_ops = { 440 404 .alloc = mp_irqdomain_alloc, 441 405 .free = mp_irqdomain_free, ··· 626 662 int trigger, int polarity) 627 663 { 628 664 int irq = gsi; 629 - 630 665 #ifdef CONFIG_X86_IO_APIC 666 + int node; 667 + struct irq_alloc_info info; 668 + 669 + node = dev ? dev_to_node(dev) : NUMA_NO_NODE; 670 + trigger = trigger == ACPI_EDGE_SENSITIVE ? 0 : 1; 671 + polarity = polarity == ACPI_ACTIVE_HIGH ? 0 : 1; 672 + ioapic_set_alloc_attr(&info, node, trigger, polarity); 673 + 631 674 mutex_lock(&acpi_ioapic_lock); 632 - irq = mp_register_gsi(dev, gsi, trigger, polarity); 675 + irq = mp_map_gsi_to_irq(gsi, IOAPIC_MAP_ALLOC, &info); 676 + /* Don't set up the ACPI SCI because it's already set up */ 677 + if (irq >= 0 && enable_update_mptable && 678 + acpi_gbl_FADT.sci_interrupt != gsi) 679 + mp_config_acpi_gsi(dev, gsi, trigger, polarity); 633 680 mutex_unlock(&acpi_ioapic_lock); 634 681 #endif 635 682 ··· 650 675 static void acpi_unregister_gsi_ioapic(u32 gsi) 651 676 { 652 677 #ifdef CONFIG_X86_IO_APIC 678 + int irq; 679 + 653 680 mutex_lock(&acpi_ioapic_lock); 654 - mp_unregister_gsi(gsi); 681 + irq = mp_map_gsi_to_irq(gsi, 0, NULL); 682 + if (irq > 0) 683 + mp_unmap_irq(irq); 655 684 mutex_unlock(&acpi_ioapic_lock); 656 685 #endif 657 686 }