Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: mtk-mdp: constify v4l2_m2m_ops structures

The v4l2_m2m_ops structures are only passed as the only
argument to v4l2_m2m_init, which is declared as const.
Thus the v4l2_m2m_ops structures themselves can be const.

Done with the help of Coccinelle.

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct v4l2_m2m_ops i@p = { ... };

@ok1@
identifier r.i;
position p;
@@
v4l2_m2m_init(&i@p)

@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct v4l2_m2m_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct v4l2_m2m_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

authored by

Julia Lawall and committed by
Mauro Carvalho Chehab
46014f61 040ffe12

+1 -1
+1 -1
drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c
··· 1225 1225 .mmap = v4l2_m2m_fop_mmap, 1226 1226 }; 1227 1227 1228 - static struct v4l2_m2m_ops mtk_mdp_m2m_ops = { 1228 + static const struct v4l2_m2m_ops mtk_mdp_m2m_ops = { 1229 1229 .device_run = mtk_mdp_m2m_device_run, 1230 1230 .job_abort = mtk_mdp_m2m_job_abort, 1231 1231 };