tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

fbdev: Remove FBINFO_DEFAULT from devm_kzalloc()'ed structs

The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags
has been allocated to zero by devm_kzalloc(). So do not set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v4:
* clarify commit message (Geert, Dan)
v2:
* fix commit message (Miguel)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-5-tzimmermann@suse.de

Thomas Zimmermann 45733d28 a0331a4b

+1 -5
-1
drivers/video/fbdev/pxafb.c
··· 1826 1826 fbi->fb.var.vmode = FB_VMODE_NONINTERLACED; 1827 1827 1828 1828 fbi->fb.fbops = &pxafb_ops; 1829 - fbi->fb.flags = FBINFO_DEFAULT; 1830 1829 fbi->fb.node = -1; 1831 1830 1832 1831 addr = fbi;
-1
drivers/video/fbdev/sa1100fb.c
··· 1089 1089 fbi->fb.var.vmode = FB_VMODE_NONINTERLACED; 1090 1090 1091 1091 fbi->fb.fbops = &sa1100fb_ops; 1092 - fbi->fb.flags = FBINFO_DEFAULT; 1093 1092 fbi->fb.monspecs = monspecs; 1094 1093 fbi->fb.pseudo_palette = fbi->pseudo_palette; 1095 1094
+1 -2
drivers/video/fbdev/wm8505fb.c
··· 285 285 fbi->fb.fix.accel = FB_ACCEL_NONE; 286 286 287 287 fbi->fb.fbops = &wm8505fb_ops; 288 - fbi->fb.flags = FBINFO_DEFAULT 289 - | FBINFO_HWACCEL_COPYAREA 288 + fbi->fb.flags = FBINFO_HWACCEL_COPYAREA 290 289 | FBINFO_HWACCEL_FILLRECT 291 290 | FBINFO_HWACCEL_XPAN 292 291 | FBINFO_HWACCEL_YPAN
-1
drivers/video/fbdev/xilinxfb.c
··· 324 324 drvdata->info.fix.line_length = pdata->xvirt * BYTES_PER_PIXEL; 325 325 326 326 drvdata->info.pseudo_palette = drvdata->pseudo_palette; 327 - drvdata->info.flags = FBINFO_DEFAULT; 328 327 drvdata->info.var = xilinx_fb_var; 329 328 drvdata->info.var.height = pdata->screen_height_mm; 330 329 drvdata->info.var.width = pdata->screen_width_mm;