Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers/block: replace use of system_unbound_wq with system_dfl_wq

Currently if a user enqueue a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistentcy cannot be addressed without refactoring the API.

system_unbound_wq should be the default workqueue so as not to enforce
locality constraints for random work whenever it's not required.

Adding system_dfl_wq to encourage its use when unbound work should be used.

queue_work() / queue_delayed_work() / mod_delayed_work() will now use the
new unbound wq: whether the user still use the old wq a warn will be
printed along with a wq redirect to the new one.

The old system_unbound_wq will be kept for a few release cycles.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

authored by

Marco Crivellari and committed by
Jens Axboe
456cefcb 51723bf9

+1 -1
+1 -1
drivers/block/zram/zram_drv.c
··· 1085 1085 work.entry = entry; 1086 1086 1087 1087 INIT_WORK_ONSTACK(&work.work, zram_sync_read); 1088 - queue_work(system_unbound_wq, &work.work); 1088 + queue_work(system_dfl_wq, &work.work); 1089 1089 flush_work(&work.work); 1090 1090 destroy_work_on_stack(&work.work); 1091 1091