Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

evm: Check size of security.evm before using it

This patch checks the size for the EVM_IMA_XATTR_DIGSIG and
EVM_XATTR_PORTABLE_DIGSIG types to ensure that the algorithm is read from
the buffer returned by vfs_getxattr_alloc().

Cc: stable@vger.kernel.org # 4.19.x
Fixes: 5feeb61183dde ("evm: Allow non-SHA1 digital signatures")
Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>

authored by

Roberto Sassu and committed by
Mimi Zohar
455b6c91 4be92db3

+6
+6
security/integrity/evm/evm_main.c
··· 184 184 break; 185 185 case EVM_IMA_XATTR_DIGSIG: 186 186 case EVM_XATTR_PORTABLE_DIGSIG: 187 + /* accept xattr with non-empty signature field */ 188 + if (xattr_len <= sizeof(struct signature_v2_hdr)) { 189 + evm_status = INTEGRITY_FAIL; 190 + goto out; 191 + } 192 + 187 193 hdr = (struct signature_v2_hdr *)xattr_data; 188 194 digest.hdr.algo = hdr->hash_algo; 189 195 rc = evm_calc_hash(dentry, xattr_name, xattr_value,