tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

net: hns: Add missing \n to end of dev_err messages, tidy up text

Trival fix, dev_err messages are missing a \n, so add it. Also
fix grammer, spelling mistake and add white spaces to various
error messages.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Colin Ian King and committed by
David S. Miller 451e856e 87089dd7

+11 -11
+11 -11
drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
··· 126 126 (enum mac_speed)speed, duplex); 127 127 if (ret) { 128 128 dev_err(mac_cb->dev, 129 - "adjust_link failed,%s mac%d ret = %#x!\n", 129 + "adjust_link failed, %s mac%d ret = %#x!\n", 130 130 mac_cb->dsaf_dev->ae_dev.name, 131 131 mac_cb->mac_id, ret); 132 132 return; ··· 149 149 if (mac_cb->dsaf_dev->dsaf_mode <= DSAF_MODE_ENABLE) { 150 150 if (mac_cb->mac_id != DSAF_MAX_PORT_NUM) { 151 151 dev_err(mac_cb->dev, 152 - "input invalid,%s mac%d vmid%d !\n", 152 + "input invalid, %s mac%d vmid%d !\n", 153 153 mac_cb->dsaf_dev->ae_dev.name, 154 154 mac_cb->mac_id, vmid); 155 155 return -EINVAL; ··· 157 157 } else if (mac_cb->dsaf_dev->dsaf_mode < DSAF_MODE_MAX) { 158 158 if (mac_cb->mac_id >= DSAF_MAX_PORT_NUM) { 159 159 dev_err(mac_cb->dev, 160 - "input invalid,%s mac%d vmid%d!\n", 160 + "input invalid, %s mac%d vmid%d!\n", 161 161 mac_cb->dsaf_dev->ae_dev.name, 162 162 mac_cb->mac_id, vmid); 163 163 return -EINVAL; 164 164 } 165 165 } else { 166 - dev_err(mac_cb->dev, "dsaf mode invalid,%s mac%d!\n", 166 + dev_err(mac_cb->dev, "dsaf mode invalid, %s mac%d!\n", 167 167 mac_cb->dsaf_dev->ae_dev.name, mac_cb->mac_id); 168 168 return -EINVAL; 169 169 } 170 170 171 171 if (vmid >= mac_cb->dsaf_dev->rcb_common[0]->max_vfn) { 172 - dev_err(mac_cb->dev, "input invalid,%s mac%d vmid%d !\n", 172 + dev_err(mac_cb->dev, "input invalid, %s mac%d vmid%d !\n", 173 173 mac_cb->dsaf_dev->ae_dev.name, mac_cb->mac_id, vmid); 174 174 return -EINVAL; 175 175 } ··· 196 196 tmp_port = vmid; 197 197 break; 198 198 default: 199 - dev_err(mac_cb->dev, "dsaf mode invalid,%s mac%d!\n", 199 + dev_err(mac_cb->dev, "dsaf mode invalid, %s mac%d!\n", 200 200 mac_cb->dsaf_dev->ae_dev.name, mac_cb->mac_id); 201 201 return -EINVAL; 202 202 } ··· 275 275 ret = hns_dsaf_add_mac_mc_port(dsaf_dev, &mac_entry); 276 276 if (ret) { 277 277 dev_err(dsaf_dev->dev, 278 - "set mac mc port failed,%s mac%d ret = %#x!\n", 278 + "set mac mc port failed, %s mac%d ret = %#x!\n", 279 279 mac_cb->dsaf_dev->ae_dev.name, 280 280 mac_cb->mac_id, ret); 281 281 return ret; ··· 305 305 old_mac = &mac_cb->addr_entry_idx[vfn]; 306 306 } else { 307 307 dev_err(mac_cb->dev, 308 - "vf queue is too large,%s mac%d queue = %#x!\n", 308 + "vf queue is too large, %s mac%d queue = %#x!\n", 309 309 mac_cb->dsaf_dev->ae_dev.name, mac_cb->mac_id, vfn); 310 310 return -EINVAL; 311 311 } ··· 547 547 struct mac_driver *mac_ctrl_drv = hns_mac_get_drv(mac_cb); 548 548 549 549 if (mac_cb->phy_if == PHY_INTERFACE_MODE_XGMII && enable) { 550 - dev_err(mac_cb->dev, "enable autoneg is not allowed!"); 550 + dev_err(mac_cb->dev, "enabling autoneg is not allowed!\n"); 551 551 return -ENOTSUPP; 552 552 } 553 553 ··· 571 571 572 572 if (mac_cb->mac_type == HNAE_PORT_DEBUG) { 573 573 if (is_ver1 && (tx_en || rx_en)) { 574 - dev_err(mac_cb->dev, "macv1 cann't enable tx/rx_pause!"); 574 + dev_err(mac_cb->dev, "macv1 can't enable tx/rx_pause!\n"); 575 575 return -EINVAL; 576 576 } 577 577 } ··· 941 941 ret = hns_mac_get_mode(mac_cb->phy_if); 942 942 if (ret < 0) { 943 943 dev_err(dsaf_dev->dev, 944 - "hns_mac_get_mode failed,mac%d ret = %#x!\n", 944 + "hns_mac_get_mode failed, mac%d ret = %#x!\n", 945 945 mac_cb->mac_id, ret); 946 946 return ret; 947 947 }