Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PM: runtime: Document that force_suspend() is incompatible with SMART_SUSPEND

pm_runtime_force_suspend() cannot be used with DPM_FLAG_SMART_SUSPEND, so
note this in the kerneldoc.

If DPM_FLAG_SMART_SUSPEND is set and the PM core cannot skip system resume
it will call pm_runtime_active() on the driver. This can lead to an
inconsistent state where:

pm_runtime_force_suspend() called ->runtime_suspend

but

device_resume_noirq() called pm_runtime_set_active()

This leaves the driver actually suspended but marked as active.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

authored by

Richard Fitzgerald and committed by
Rafael J. Wysocki
450316dc b7bfaa76

+4
+4
drivers/base/power/runtime.c
··· 1864 1864 * sure the device is put into low power state and it should only be used during 1865 1865 * system-wide PM transitions to sleep states. It assumes that the analogous 1866 1866 * pm_runtime_force_resume() will be used to resume the device. 1867 + * 1868 + * Do not use with DPM_FLAG_SMART_SUSPEND as this can lead to an inconsistent 1869 + * state where this function has called the ->runtime_suspend callback but the 1870 + * PM core marks the driver as runtime active. 1867 1871 */ 1868 1872 int pm_runtime_force_suspend(struct device *dev) 1869 1873 {