Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ALSA: sparc/cs4231: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-173-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
44e4b6ee cbde81bc

+2 -4
+2 -4
sound/sparc/cs4231.c
··· 2069 2069 return -ENODEV; 2070 2070 } 2071 2071 2072 - static int cs4231_remove(struct platform_device *op) 2072 + static void cs4231_remove(struct platform_device *op) 2073 2073 { 2074 2074 struct snd_cs4231 *chip = dev_get_drvdata(&op->dev); 2075 2075 2076 2076 snd_card_free(chip->card); 2077 - 2078 - return 0; 2079 2077 } 2080 2078 2081 2079 static const struct of_device_id cs4231_match[] = { ··· 2095 2097 .of_match_table = cs4231_match, 2096 2098 }, 2097 2099 .probe = cs4231_probe, 2098 - .remove = cs4231_remove, 2100 + .remove_new = cs4231_remove, 2099 2101 }; 2100 2102 2101 2103 module_platform_driver(cs4231_driver);