Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

i2c-pnx: Correct use of request_region/request_mem_region

request_mem_region should be used when ioremap is used subsequently.
release_region is then correspondingly replaced by release_mem_region.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
expression start,E;
@@

- request_region
+ request_mem_region
(start,...)
... when != request_mem_region(start,...)
when != start = E
ioremap(start,...)

@@
expression r.start;
@@

- release_region
+ release_mem_region
(start,...)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Vitaly Wool <vitalywool@gmail.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>

authored by

Julia Lawall and committed by
Jean Delvare
449d2c75 a1867d36

+4 -3
+4 -3
drivers/i2c/busses/i2c-pnx.c
··· 586 586 alg_data->mif.timer.data = (unsigned long)i2c_pnx->adapter; 587 587 588 588 /* Register I/O resource */ 589 - if (!request_region(alg_data->base, I2C_PNX_REGION_SIZE, pdev->name)) { 589 + if (!request_mem_region(alg_data->base, I2C_PNX_REGION_SIZE, 590 + pdev->name)) { 590 591 dev_err(&pdev->dev, 591 592 "I/O region 0x%08x for I2C already in use.\n", 592 593 alg_data->base); ··· 651 650 out_unmap: 652 651 iounmap((void *)alg_data->ioaddr); 653 652 out_release: 654 - release_region(alg_data->base, I2C_PNX_REGION_SIZE); 653 + release_mem_region(alg_data->base, I2C_PNX_REGION_SIZE); 655 654 out_drvdata: 656 655 platform_set_drvdata(pdev, NULL); 657 656 out: ··· 668 667 i2c_del_adapter(adap); 669 668 i2c_pnx->set_clock_stop(pdev); 670 669 iounmap((void *)alg_data->ioaddr); 671 - release_region(alg_data->base, I2C_PNX_REGION_SIZE); 670 + release_mem_region(alg_data->base, I2C_PNX_REGION_SIZE); 672 671 platform_set_drvdata(pdev, NULL); 673 672 674 673 return 0;