Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

x86: Remove warning and warning_symbol from struct stacktrace_ops

Both warning and warning_symbol are nowhere used.
Let's get rid of them.

Signed-off-by: Richard Weinberger <richard@nod.at>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Soeren Sandmann Pedersen <ssp@redhat.com>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: x86 <x86@kernel.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Link: http://lkml.kernel.org/r/1305205872-10321-2-git-send-email-richard@nod.at
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>

authored by

Richard Weinberger and committed by
Frederic Weisbecker
449a66fd 2b348a77

-58
-3
arch/x86/include/asm/stacktrace.h
··· 37 37 /* Generic stack tracer with callbacks */ 38 38 39 39 struct stacktrace_ops { 40 - void (*warning)(void *data, char *msg); 41 - /* msg must contain %s for the symbol */ 42 - void (*warning_symbol)(void *data, char *msg, unsigned long symbol); 43 40 void (*address)(void *data, unsigned long address, int reliable); 44 41 /* On negative return stop dumping */ 45 42 int (*stack)(void *data, char *name);
-13
arch/x86/kernel/cpu/perf_event.c
··· 1773 1773 * callchain support 1774 1774 */ 1775 1775 1776 - static void 1777 - backtrace_warning_symbol(void *data, char *msg, unsigned long symbol) 1778 - { 1779 - /* Ignore warnings */ 1780 - } 1781 - 1782 - static void backtrace_warning(void *data, char *msg) 1783 - { 1784 - /* Ignore warnings */ 1785 - } 1786 - 1787 1776 static int backtrace_stack(void *data, char *name) 1788 1777 { 1789 1778 return 0; ··· 1786 1797 } 1787 1798 1788 1799 static const struct stacktrace_ops backtrace_ops = { 1789 - .warning = backtrace_warning, 1790 - .warning_symbol = backtrace_warning_symbol, 1791 1800 .stack = backtrace_stack, 1792 1801 .address = backtrace_address, 1793 1802 .walk_stack = print_context_stack_bp,
-16
arch/x86/kernel/dumpstack.c
··· 135 135 } 136 136 EXPORT_SYMBOL_GPL(print_context_stack_bp); 137 137 138 - 139 - static void 140 - print_trace_warning_symbol(void *data, char *msg, unsigned long symbol) 141 - { 142 - printk(data); 143 - print_symbol(msg, symbol); 144 - printk("\n"); 145 - } 146 - 147 - static void print_trace_warning(void *data, char *msg) 148 - { 149 - printk("%s%s\n", (char *)data, msg); 150 - } 151 - 152 138 static int print_trace_stack(void *data, char *name) 153 139 { 154 140 printk("%s <%s> ", (char *)data, name); ··· 152 166 } 153 167 154 168 static const struct stacktrace_ops print_trace_ops = { 155 - .warning = print_trace_warning, 156 - .warning_symbol = print_trace_warning_symbol, 157 169 .stack = print_trace_stack, 158 170 .address = print_trace_address, 159 171 .walk_stack = print_context_stack,
-13
arch/x86/kernel/stacktrace.c
··· 9 9 #include <linux/uaccess.h> 10 10 #include <asm/stacktrace.h> 11 11 12 - static void save_stack_warning(void *data, char *msg) 13 - { 14 - } 15 - 16 - static void 17 - save_stack_warning_symbol(void *data, char *msg, unsigned long symbol) 18 - { 19 - } 20 - 21 12 static int save_stack_stack(void *data, char *name) 22 13 { 23 14 return 0; ··· 44 53 } 45 54 46 55 static const struct stacktrace_ops save_stack_ops = { 47 - .warning = save_stack_warning, 48 - .warning_symbol = save_stack_warning_symbol, 49 56 .stack = save_stack_stack, 50 57 .address = save_stack_address, 51 58 .walk_stack = print_context_stack, 52 59 }; 53 60 54 61 static const struct stacktrace_ops save_stack_ops_nosched = { 55 - .warning = save_stack_warning, 56 - .warning_symbol = save_stack_warning_symbol, 57 62 .stack = save_stack_stack, 58 63 .address = save_stack_address_nosched, 59 64 .walk_stack = print_context_stack,
-13
arch/x86/oprofile/backtrace.c
··· 16 16 #include <asm/stacktrace.h> 17 17 #include <linux/compat.h> 18 18 19 - static void backtrace_warning_symbol(void *data, char *msg, 20 - unsigned long symbol) 21 - { 22 - /* Ignore warnings */ 23 - } 24 - 25 - static void backtrace_warning(void *data, char *msg) 26 - { 27 - /* Ignore warnings */ 28 - } 29 - 30 19 static int backtrace_stack(void *data, char *name) 31 20 { 32 21 /* Yes, we want all stacks */ ··· 31 42 } 32 43 33 44 static struct stacktrace_ops backtrace_ops = { 34 - .warning = backtrace_warning, 35 - .warning_symbol = backtrace_warning_symbol, 36 45 .stack = backtrace_stack, 37 46 .address = backtrace_address, 38 47 .walk_stack = print_context_stack,