Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: rtl8193*: Remove double test

The 1 element of the array is tested twice. Change the code so that the
remaining 3 element of the array is tested instead of testing the 1 element
a second time.

The sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@expression@
expression E;
@@

(
* E
|| ... || E
|
* E
&& ... && E
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

authored by

Julia Lawall and committed by
Greg Kroah-Hartman
4498dbcd 15300c1d

+2 -2
+1 -1
drivers/staging/rtl8192e/ieee80211/ieee80211_rx.c
··· 2579 2579 if(src->wmm_param[0].ac_aci_acm_aifsn|| \ 2580 2580 src->wmm_param[1].ac_aci_acm_aifsn|| \ 2581 2581 src->wmm_param[2].ac_aci_acm_aifsn|| \ 2582 - src->wmm_param[1].ac_aci_acm_aifsn) { 2582 + src->wmm_param[3].ac_aci_acm_aifsn) { 2583 2583 memcpy(dst->wmm_param, src->wmm_param, WME_AC_PRAM_LEN); 2584 2584 } 2585 2585 //dst->QoS_Enable = src->QoS_Enable;
+1 -1
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
··· 2391 2391 if(src->wmm_param[0].ac_aci_acm_aifsn|| \ 2392 2392 src->wmm_param[1].ac_aci_acm_aifsn|| \ 2393 2393 src->wmm_param[2].ac_aci_acm_aifsn|| \ 2394 - src->wmm_param[1].ac_aci_acm_aifsn) { 2394 + src->wmm_param[3].ac_aci_acm_aifsn) { 2395 2395 memcpy(dst->wmm_param, src->wmm_param, WME_AC_PRAM_LEN); 2396 2396 } 2397 2397 //dst->QoS_Enable = src->QoS_Enable;