Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm: Remove struct drm_mode_config_funcs.output_poll_changed

The output_poll_changed hook in struct drm_mode_config_funcs is
unused. Remove it. The helper drm_client_dev_hotplug() implements
the callback's functionality.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20240812083000.337744-10-tzimmermann@suse.de

+1 -25
+1 -9
drivers/gpu/drm/drm_probe_helper.c
··· 714 714 * @dev: drm_device whose connector state changed 715 715 * 716 716 * This function fires off the uevent for userspace and also calls the 717 - * output_poll_changed function, which is most commonly used to inform the fbdev 717 + * client hotplug function, which is most commonly used to inform the fbdev 718 718 * emulation code and allow it to update the fbcon output configuration. 719 719 * 720 720 * Drivers should call this from their hotplug handling code when a change is ··· 730 730 */ 731 731 void drm_kms_helper_hotplug_event(struct drm_device *dev) 732 732 { 733 - /* send a uevent + call fbdev */ 734 733 drm_sysfs_hotplug_event(dev); 735 - if (dev->mode_config.funcs->output_poll_changed) 736 - dev->mode_config.funcs->output_poll_changed(dev); 737 - 738 734 drm_client_dev_hotplug(dev); 739 735 } 740 736 EXPORT_SYMBOL(drm_kms_helper_hotplug_event); ··· 746 750 { 747 751 struct drm_device *dev = connector->dev; 748 752 749 - /* send a uevent + call fbdev */ 750 753 drm_sysfs_connector_hotplug_event(connector); 751 - if (dev->mode_config.funcs->output_poll_changed) 752 - dev->mode_config.funcs->output_poll_changed(dev); 753 - 754 754 drm_client_dev_hotplug(dev); 755 755 } 756 756 EXPORT_SYMBOL(drm_kms_helper_connector_hotplug_event);
-16
include/drm/drm_mode_config.h
··· 98 98 const struct drm_format_info *(*get_format_info)(const struct drm_mode_fb_cmd2 *mode_cmd); 99 99 100 100 /** 101 - * @output_poll_changed: 102 - * 103 - * Callback used by helpers to inform the driver of output configuration 104 - * changes. 105 - * 106 - * Drivers implementing fbdev emulation use drm_kms_helper_hotplug_event() 107 - * to call this hook to inform the fbdev helper of output changes. 108 - * 109 - * This hook is deprecated, drivers should instead implement fbdev 110 - * support with struct drm_client, which takes care of any necessary 111 - * hotplug event forwarding already without further involvement by 112 - * the driver. 113 - */ 114 - void (*output_poll_changed)(struct drm_device *dev); 115 - 116 - /** 117 101 * @mode_valid: 118 102 * 119 103 * Device specific validation of display modes. Can be used to reject