Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

memstick: remove deprecated use of pci api

Replace occurences of the pci api by appropriate call to the dma api.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr)

@deprecated@
idexpression id;
position p;
@@

(
pci_dma_supported@p ( id, ...)
|
pci_alloc_consistent@p ( id, ...)
)

@bad1@
idexpression id;
position deprecated.p;
@@
...when != &id->dev
when != pci_get_drvdata ( id )
when != pci_enable_device ( id )
(
pci_dma_supported@p ( id, ...)
|
pci_alloc_consistent@p ( id, ...)
)

@depends on !bad1@
idexpression id;
expression direction;
position deprecated.p;
@@

(
- pci_dma_supported@p ( id,
+ dma_supported ( &id->dev,
...
+ , GFP_ATOMIC
)
|
- pci_alloc_consistent@p ( id,
+ dma_alloc_coherent ( &id->dev,
...
+ , GFP_ATOMIC
)
)

Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Quentin Lambert and committed by
Linus Torvalds
43abdbce 196a4f82

+11 -11
+6 -6
drivers/memstick/host/jmb38x_ms.c
··· 419 419 } 420 420 421 421 if (host->cmd_flags & DMA_DATA) { 422 - if (1 != pci_map_sg(host->chip->pdev, &host->req->sg, 1, 422 + if (1 != dma_map_sg(&host->chip->pdev->dev, &host->req->sg, 1, 423 423 host->req->data_dir == READ 424 - ? PCI_DMA_FROMDEVICE 425 - : PCI_DMA_TODEVICE)) { 424 + ? DMA_FROM_DEVICE 425 + : DMA_TO_DEVICE)) { 426 426 host->req->error = -ENOMEM; 427 427 return host->req->error; 428 428 } ··· 487 487 writel(0, host->addr + DMA_CONTROL); 488 488 489 489 if (host->cmd_flags & DMA_DATA) { 490 - pci_unmap_sg(host->chip->pdev, &host->req->sg, 1, 490 + dma_unmap_sg(&host->chip->pdev->dev, &host->req->sg, 1, 491 491 host->req->data_dir == READ 492 - ? PCI_DMA_FROMDEVICE : PCI_DMA_TODEVICE); 492 + ? DMA_FROM_DEVICE : DMA_TO_DEVICE); 493 493 } else { 494 494 t_val = readl(host->addr + INT_STATUS_ENABLE); 495 495 if (host->req->data_dir == READ) ··· 925 925 int pci_dev_busy = 0; 926 926 int rc, cnt; 927 927 928 - rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(32)); 928 + rc = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32)); 929 929 if (rc) 930 930 return rc; 931 931
+5 -5
drivers/memstick/host/r592.c
··· 754 754 goto error2; 755 755 756 756 pci_set_master(pdev); 757 - error = pci_set_dma_mask(pdev, DMA_BIT_MASK(32)); 757 + error = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32)); 758 758 if (error) 759 759 goto error3; 760 760 ··· 787 787 } 788 788 789 789 /* This is just a precation, so don't fail */ 790 - dev->dummy_dma_page = pci_alloc_consistent(pdev, PAGE_SIZE, 791 - &dev->dummy_dma_page_physical_address); 790 + dev->dummy_dma_page = dma_alloc_coherent(&pdev->dev, PAGE_SIZE, 791 + &dev->dummy_dma_page_physical_address, GFP_KERNEL); 792 792 r592_stop_dma(dev , 0); 793 793 794 794 if (request_irq(dev->irq, &r592_irq, IRQF_SHARED, ··· 805 805 free_irq(dev->irq, dev); 806 806 error6: 807 807 if (dev->dummy_dma_page) 808 - pci_free_consistent(pdev, PAGE_SIZE, dev->dummy_dma_page, 808 + dma_free_coherent(&pdev->dev, PAGE_SIZE, dev->dummy_dma_page, 809 809 dev->dummy_dma_page_physical_address); 810 810 811 811 kthread_stop(dev->io_thread); ··· 845 845 memstick_free_host(dev->host); 846 846 847 847 if (dev->dummy_dma_page) 848 - pci_free_consistent(pdev, PAGE_SIZE, dev->dummy_dma_page, 848 + dma_free_coherent(&pdev->dev, PAGE_SIZE, dev->dummy_dma_page, 849 849 dev->dummy_dma_page_physical_address); 850 850 } 851 851