Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

make blkdev_put() return void

same story as with the previous patches - note that return
value of blkdev_close() is lost, since there's nowhere the
caller (__fput()) could return it to.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Al Viro 4385bab1 db2a144b

+22 -46
+6 -8
fs/block_dev.c
··· 1045 1045 } 1046 1046 EXPORT_SYMBOL(bd_set_size); 1047 1047 1048 - static int __blkdev_put(struct block_device *bdev, fmode_t mode, int for_part); 1048 + static void __blkdev_put(struct block_device *bdev, fmode_t mode, int for_part); 1049 1049 1050 1050 /* 1051 1051 * bd_mutex locking: ··· 1400 1400 return blkdev_get(bdev, filp->f_mode, filp); 1401 1401 } 1402 1402 1403 - static int __blkdev_put(struct block_device *bdev, fmode_t mode, int for_part) 1403 + static void __blkdev_put(struct block_device *bdev, fmode_t mode, int for_part) 1404 1404 { 1405 - int ret = 0; 1406 1405 struct gendisk *disk = bdev->bd_disk; 1407 1406 struct block_device *victim = NULL; 1408 1407 ··· 1440 1441 bdput(bdev); 1441 1442 if (victim) 1442 1443 __blkdev_put(victim, mode, 1); 1443 - return ret; 1444 1444 } 1445 1445 1446 - int blkdev_put(struct block_device *bdev, fmode_t mode) 1446 + void blkdev_put(struct block_device *bdev, fmode_t mode) 1447 1447 { 1448 1448 mutex_lock(&bdev->bd_mutex); 1449 1449 ··· 1486 1488 1487 1489 mutex_unlock(&bdev->bd_mutex); 1488 1490 1489 - return __blkdev_put(bdev, mode, 0); 1491 + __blkdev_put(bdev, mode, 0); 1490 1492 } 1491 1493 EXPORT_SYMBOL(blkdev_put); 1492 1494 1493 1495 static int blkdev_close(struct inode * inode, struct file * filp) 1494 1496 { 1495 1497 struct block_device *bdev = I_BDEV(filp->f_mapping->host); 1496 - 1497 - return blkdev_put(bdev, filp->f_mode); 1498 + blkdev_put(bdev, filp->f_mode); 1499 + return 0; 1498 1500 } 1499 1501 1500 1502 static long block_ioctl(struct file *file, unsigned cmd, unsigned long arg)
+4 -7
fs/ext3/super.c
··· 362 362 /* 363 363 * Release the journal device 364 364 */ 365 - static int ext3_blkdev_put(struct block_device *bdev) 365 + static void ext3_blkdev_put(struct block_device *bdev) 366 366 { 367 - return blkdev_put(bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL); 367 + blkdev_put(bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL); 368 368 } 369 369 370 - static int ext3_blkdev_remove(struct ext3_sb_info *sbi) 370 + static void ext3_blkdev_remove(struct ext3_sb_info *sbi) 371 371 { 372 372 struct block_device *bdev; 373 - int ret = -ENODEV; 374 - 375 373 bdev = sbi->journal_bdev; 376 374 if (bdev) { 377 - ret = ext3_blkdev_put(bdev); 375 + ext3_blkdev_put(bdev); 378 376 sbi->journal_bdev = NULL; 379 377 } 380 - return ret; 381 378 } 382 379 383 380 static inline struct inode *orphan_list_entry(struct list_head *l)
+4 -7
fs/ext4/super.c
··· 703 703 /* 704 704 * Release the journal device 705 705 */ 706 - static int ext4_blkdev_put(struct block_device *bdev) 706 + static void ext4_blkdev_put(struct block_device *bdev) 707 707 { 708 - return blkdev_put(bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL); 708 + blkdev_put(bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL); 709 709 } 710 710 711 - static int ext4_blkdev_remove(struct ext4_sb_info *sbi) 711 + static void ext4_blkdev_remove(struct ext4_sb_info *sbi) 712 712 { 713 713 struct block_device *bdev; 714 - int ret = -ENODEV; 715 - 716 714 bdev = sbi->journal_bdev; 717 715 if (bdev) { 718 - ret = ext4_blkdev_put(bdev); 716 + ext4_blkdev_put(bdev); 719 717 sbi->journal_bdev = NULL; 720 718 } 721 - return ret; 722 719 } 723 720 724 721 static inline struct inode *orphan_list_entry(struct list_head *l)
+1 -1
fs/nfs/blocklayout/blocklayout.h
··· 173 173 /* blocklayoutdev.c */ 174 174 ssize_t bl_pipe_downcall(struct file *, const char __user *, size_t); 175 175 void bl_pipe_destroy_msg(struct rpc_pipe_msg *); 176 - int nfs4_blkdev_put(struct block_device *bdev); 176 + void nfs4_blkdev_put(struct block_device *bdev); 177 177 struct pnfs_block_dev *nfs4_blk_decode_device(struct nfs_server *server, 178 178 struct pnfs_device *dev); 179 179 int nfs4_blk_process_layoutget(struct pnfs_layout_hdr *lo,
+2 -2
fs/nfs/blocklayout/blocklayoutdev.c
··· 56 56 /* 57 57 * Release the block device 58 58 */ 59 - int nfs4_blkdev_put(struct block_device *bdev) 59 + void nfs4_blkdev_put(struct block_device *bdev) 60 60 { 61 61 dprintk("%s for device %d:%d\n", __func__, MAJOR(bdev->bd_dev), 62 62 MINOR(bdev->bd_dev)); 63 - return blkdev_put(bdev, FMODE_READ); 63 + blkdev_put(bdev, FMODE_READ); 64 64 } 65 65 66 66 ssize_t bl_pipe_downcall(struct file *filp, const char __user *src,
+1 -7
fs/nfs/blocklayout/blocklayoutdm.c
··· 88 88 */ 89 89 static void nfs4_blk_metadev_release(struct pnfs_block_dev *bdev) 90 90 { 91 - int rv; 92 - 93 91 dprintk("%s Releasing\n", __func__); 94 - rv = nfs4_blkdev_put(bdev->bm_mdev); 95 - if (rv) 96 - printk(KERN_ERR "NFS: %s nfs4_blkdev_put returns %d\n", 97 - __func__, rv); 98 - 92 + nfs4_blkdev_put(bdev->bm_mdev); 99 93 dev_remove(bdev->net, bdev->bm_mdev->bd_dev); 100 94 } 101 95
+3 -13
fs/reiserfs/journal.c
··· 97 97 static int can_dirty(struct reiserfs_journal_cnode *cn); 98 98 static int journal_join(struct reiserfs_transaction_handle *th, 99 99 struct super_block *sb, unsigned long nblocks); 100 - static int release_journal_dev(struct super_block *super, 100 + static void release_journal_dev(struct super_block *super, 101 101 struct reiserfs_journal *journal); 102 102 static int dirty_one_transaction(struct super_block *s, 103 103 struct reiserfs_journal_list *jl); ··· 2532 2532 SB_JOURNAL(sb)->j_current_jl = alloc_journal_list(sb); 2533 2533 } 2534 2534 2535 - static int release_journal_dev(struct super_block *super, 2535 + static void release_journal_dev(struct super_block *super, 2536 2536 struct reiserfs_journal *journal) 2537 2537 { 2538 - int result; 2539 - 2540 - result = 0; 2541 - 2542 2538 if (journal->j_dev_bd != NULL) { 2543 - result = blkdev_put(journal->j_dev_bd, journal->j_dev_mode); 2539 + blkdev_put(journal->j_dev_bd, journal->j_dev_mode); 2544 2540 journal->j_dev_bd = NULL; 2545 2541 } 2546 - 2547 - if (result != 0) { 2548 - reiserfs_warning(super, "sh-457", 2549 - "Cannot release journal device: %i", result); 2550 - } 2551 - return result; 2552 2542 } 2553 2543 2554 2544 static int journal_init_dev(struct super_block *super,
+1 -1
include/linux/fs.h
··· 2091 2091 void *holder); 2092 2092 extern struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, 2093 2093 void *holder); 2094 - extern int blkdev_put(struct block_device *bdev, fmode_t mode); 2094 + extern void blkdev_put(struct block_device *bdev, fmode_t mode); 2095 2095 #ifdef CONFIG_SYSFS 2096 2096 extern int bd_link_disk_holder(struct block_device *bdev, struct gendisk *disk); 2097 2097 extern void bd_unlink_disk_holder(struct block_device *bdev,