Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: bcmgenet: Fix a resource leak in an error handling path in the probe functin

If the 'register_netdev()' call fails, we must undo a previous
'bcmgenet_mii_init()' call.

Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20201212182005.120437-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Christophe JAILLET and committed by
Jakub Kicinski
4375ada0 54a57d1c

+3 -1
+3 -1
drivers/net/ethernet/broadcom/genet/bcmgenet.c
··· 4069 4069 clk_disable_unprepare(priv->clk); 4070 4070 4071 4071 err = register_netdev(dev); 4072 - if (err) 4072 + if (err) { 4073 + bcmgenet_mii_exit(dev); 4073 4074 goto err; 4075 + } 4074 4076 4075 4077 return err; 4076 4078