Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

firmware: qcom_scm: update comment for ICE-related functions

The SCM calls QCOM_SCM_ES_INVALIDATE_ICE_KEY and
QCOM_SCM_ES_CONFIG_SET_ICE_KEY are also needed for eMMC inline
encryption support, not just for UFS. Update the comments accordingly.

Reviewed-by: Satya Tangirala <satyat@google.com>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Link: https://lore.kernel.org/r/20210125183810.198008-7-ebiggers@kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

authored by

Eric Biggers and committed by
Ulf Hansson
433611ea 0a0c866f

+11 -5
+11 -5
drivers/firmware/qcom_scm.c
··· 965 965 * qcom_scm_ice_invalidate_key() - Invalidate an inline encryption key 966 966 * @index: the keyslot to invalidate 967 967 * 968 - * The UFSHCI standard defines a standard way to do this, but it doesn't work on 969 - * these SoCs; only this SCM call does. 968 + * The UFSHCI and eMMC standards define a standard way to do this, but it 969 + * doesn't work on these SoCs; only this SCM call does. 970 + * 971 + * It is assumed that the SoC has only one ICE instance being used, as this SCM 972 + * call doesn't specify which ICE instance the keyslot belongs to. 970 973 * 971 974 * Return: 0 on success; -errno on failure. 972 975 */ ··· 998 995 * units, e.g. 1 = 512 bytes, 8 = 4096 bytes, etc. 999 996 * 1000 997 * Program a key into a keyslot of Qualcomm ICE (Inline Crypto Engine), where it 1001 - * can then be used to encrypt/decrypt UFS I/O requests inline. 998 + * can then be used to encrypt/decrypt UFS or eMMC I/O requests inline. 1002 999 * 1003 - * The UFSHCI standard defines a standard way to do this, but it doesn't work on 1004 - * these SoCs; only this SCM call does. 1000 + * The UFSHCI and eMMC standards define a standard way to do this, but it 1001 + * doesn't work on these SoCs; only this SCM call does. 1002 + * 1003 + * It is assumed that the SoC has only one ICE instance being used, as this SCM 1004 + * call doesn't specify which ICE instance the keyslot belongs to. 1005 1005 * 1006 1006 * Return: 0 on success; -errno on failure. 1007 1007 */