Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

regulator: rohm-generic: remove unused dummies

Function rohm_regulator_set_voltage_sel_restricted() and
rohm_regulator_set_dvs_levels() had inlined dummy implementations for
cases when the real implementation was not configured in.

All of the drivers who issue the call to these functions do SELECT the
real implementation from the Kconfig. There should be no cases where the
real implementation was not selected by the drivers using these
functions - such a situation is likely to be an error which deserves to be
noticed at compile-time.

These dummies could in theory be used for compile-testing the drivers
only (without the generic rohm regulator pieces). However, for such
compile testing we should manually drop the selection from KConfig - and
I guess that if it does not work out-of-the-box, then it is not going to
happen. Especially when there should be no reason to omit
compile-testing the generic rohm_regulator part.

Crash test dummies.

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Link: https://lore.kernel.org/r/YZ3UXXrk/Efe7Scj@fedora
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Matti Vaittinen and committed by
Mark Brown
432dd1fc a764ff77

-14
-14
include/linux/mfd/rohm-generic.h
··· 82 82 83 83 int rohm_regulator_set_voltage_sel_restricted(struct regulator_dev *rdev, 84 84 unsigned int sel); 85 - #else 86 - static inline int rohm_regulator_set_dvs_levels(const struct rohm_dvs_config *dvs, 87 - struct device_node *np, 88 - const struct regulator_desc *desc, 89 - struct regmap *regmap) 90 - { 91 - return 0; 92 - } 93 - 94 - static inline int rohm_regulator_set_voltage_sel_restricted(struct regulator_dev *rdev, 95 - unsigned int sel) 96 - { 97 - return 0; 98 - } 99 85 #endif 100 86 101 87 #endif