tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

Staging: ced1401: Fix no new typedef warning in ced_ioctl.h

This patch fixes following checkpatch.pl warnings:
WARNING:do not add new typedefs.All the related files have been modified.

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Monam Agarwal and committed by
Greg Kroah-Hartman 431cd0e5 5f3ccfcf

+8 -8
+2 -2
drivers/staging/ced1401/ced_ioc.c
··· 779 779 ** pretend that whatever the user asked for was achieved, so we return 1 if 780 780 ** try to create one, and 0 if they ask to remove (assuming all else was OK). 781 781 ****************************************************************************/ 782 - int SetEvent(DEVICE_EXTENSION *pdx, TRANSFEREVENT __user *pTE) 782 + int SetEvent(DEVICE_EXTENSION *pdx, struct transfer_event __user *pTE) 783 783 { 784 784 int iReturn = U14ERR_NOERROR; 785 - TRANSFEREVENT te; 785 + struct transfer_event te; 786 786 787 787 /* get a local copy of the data */ 788 788 if (copy_from_user(&te, pTE, sizeof(te)))
+4 -4
drivers/staging/ced1401/ced_ioctl.h
··· 34 34 }; 35 35 36 36 37 - typedef struct TransferEvent { 37 + struct transfer_event { 38 38 unsigned int dwStart; /* offset into the area */ 39 39 unsigned int dwLength; /* length of the region */ 40 40 unsigned short wAreaNum; /* the area number */ 41 41 unsigned short wFlags; /* bit 0 set for toHost */ 42 42 int iSetEvent; /* could be dummy in LINUX */ 43 - } TRANSFEREVENT; 43 + }; 44 44 45 45 #define MAX_TRANSFER_SIZE 0x4000 /* Maximum data bytes per IRP */ 46 46 #define MAX_AREA_LENGTH 0x100000 /* Maximum size of transfer area */ ··· 93 93 94 94 #define IOCTL_CED_SETTRANSFER _IOW(CED_MAGIC_IOC, 11, struct transfer_area_desc) 95 95 #define IOCTL_CED_UNSETTRANSFER _IO(CED_MAGIC_IOC, 12) 96 - #define IOCTL_CED_SETEVENT _IOW(CED_MAGIC_IOC, 13, TRANSFEREVENT) 96 + #define IOCTL_CED_SETEVENT _IOW(CED_MAGIC_IOC, 13, struct transfer_event) 97 97 #define IOCTL_CED_GETOUTBUFSPACE _IO(CED_MAGIC_IOC, 14) 98 98 #define IOCTL_CED_GETBASEADDRESS _IO(CED_MAGIC_IOC, 15) 99 99 #define IOCTL_CED_GETDRIVERREVISION _IO(CED_MAGIC_IOC, 16) ··· 199 199 return ioctl(fh, IOCTL_CED_UNSETTRANSFER, nArea); 200 200 } 201 201 202 - inline int CED_SetEvent(int fh, TRANSFEREVENT *pTE) 202 + inline int CED_SetEvent(int fh, struct transfer_event *pTE) 203 203 { 204 204 return ioctl(fh, IOCTL_CED_SETEVENT, pTE); 205 205 }
+1 -1
drivers/staging/ced1401/usb1401.c
··· 1257 1257 return UnsetTransfer(pdx, (int)ulArg); 1258 1258 1259 1259 case _IOC_NR(IOCTL_CED_SETEVENT): 1260 - return SetEvent(pdx, (TRANSFEREVENT __user *) ulArg); 1260 + return SetEvent(pdx, (struct transfer_event __user *) ulArg); 1261 1261 1262 1262 case _IOC_NR(IOCTL_CED_GETOUTBUFSPACE): 1263 1263 return GetOutBufSpace(pdx);
+1 -1
drivers/staging/ced1401/usb1401.h
··· 220 220 extern int GetString(DEVICE_EXTENSION *pdx, char __user *pUser, int n); 221 221 extern int SetTransfer(DEVICE_EXTENSION *pdx, struct transfer_area_desc __user *pTD); 222 222 extern int UnsetTransfer(DEVICE_EXTENSION *pdx, int nArea); 223 - extern int SetEvent(DEVICE_EXTENSION *pdx, TRANSFEREVENT __user *pTE); 223 + extern int SetEvent(DEVICE_EXTENSION *pdx, struct transfer_event __user *pTE); 224 224 extern int Stat1401(DEVICE_EXTENSION *pdx); 225 225 extern int LineCount(DEVICE_EXTENSION *pdx); 226 226 extern int GetOutBufSpace(DEVICE_EXTENSION *pdx);