Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

sfc: revert changes to NIC revision numbers

The revision enum values (eg EFX_REV_HUNT_A0) form part of our API,
and are included in ethtool. If these are inconsistent then ethtool
will print garbage for a register dump (ethtool -d).

Fixes: 5a6681e22c14 ("sfc: separate out SFC4000 ("Falcon") support into new sfc-falcon driver")
Signed-off-by: Edward Cree <ecree@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Bert Kenward and committed by
David S. Miller
42e6cae1 b12ca80c

+6 -2
+6 -2
drivers/net/ethernet/sfc/nic.h
··· 18 18 #include "mcdi.h" 19 19 20 20 enum { 21 - EFX_REV_SIENA_A0 = 0, 22 - EFX_REV_HUNT_A0 = 1, 21 + /* Revisions 0-2 were Falcon A0, A1 and B0 respectively. 22 + * They are not supported by this driver but these revision numbers 23 + * form part of the ethtool API for register dumping. 24 + */ 25 + EFX_REV_SIENA_A0 = 3, 26 + EFX_REV_HUNT_A0 = 4, 23 27 }; 24 28 25 29 static inline int efx_nic_rev(struct efx_nic *efx)