Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

slimbus: qcom: fix potential NULL dereference in qcom_slim_prg_slew()

platform_get_resource_byname() may fail and in this case a NULL
dereference will occur.

Fix it to use devm_platform_ioremap_resource_byname() instead of calling
platform_get_resource_byname() and devm_ioremap().

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = \(platform_get_resource\|platform_get_resource_byname\)(pdev, t,
n);
+ if (!res)
+ return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Fixes: ad7fcbc308b0 ("slimbus: qcom: Add Qualcomm Slimbus controller driver")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1607392473-20610-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Zhang Changzhong and committed by
Greg Kroah-Hartman
428bb001 1c12c270

+2 -7
+2 -7
drivers/slimbus/qcom-ctrl.c
··· 472 472 static void qcom_slim_prg_slew(struct platform_device *pdev, 473 473 struct qcom_slim_ctrl *ctrl) 474 474 { 475 - struct resource *slew_mem; 476 - 477 475 if (!ctrl->slew_reg) { 478 476 /* SLEW RATE register for this SLIMbus */ 479 - slew_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, 480 - "slew"); 481 - ctrl->slew_reg = devm_ioremap(&pdev->dev, slew_mem->start, 482 - resource_size(slew_mem)); 483 - if (!ctrl->slew_reg) 477 + ctrl->slew_reg = devm_platform_ioremap_resource_byname(pdev, "slew"); 478 + if (IS_ERR(ctrl->slew_reg)) 484 479 return; 485 480 } 486 481