Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

power: supply: wm8350_power: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230918133700.1254499-32-u.kleine-koenig@pengutronix.de
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

authored by

Uwe Kleine-König and committed by
Sebastian Reichel
42720969 dab68bbb

+2 -3
+2 -3
drivers/power/supply/wm8350_power.c
··· 579 579 return ret; 580 580 } 581 581 582 - static int wm8350_power_remove(struct platform_device *pdev) 582 + static void wm8350_power_remove(struct platform_device *pdev) 583 583 { 584 584 struct wm8350 *wm8350 = platform_get_drvdata(pdev); 585 585 struct wm8350_power *power = &wm8350->power; ··· 589 589 power_supply_unregister(power->battery); 590 590 power_supply_unregister(power->ac); 591 591 power_supply_unregister(power->usb); 592 - return 0; 593 592 } 594 593 595 594 static struct platform_driver wm8350_power_driver = { 596 595 .probe = wm8350_power_probe, 597 - .remove = wm8350_power_remove, 596 + .remove_new = wm8350_power_remove, 598 597 .driver = { 599 598 .name = "wm8350-power", 600 599 },