Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev/atafb: Initialize fb_ops to fbdev I/O-memory helpers

Initialize the instance of struct fb_ops with fbdev initializer
macros for framebuffers in I/O address space. Set the read/write,
draw and mmap callbacks to the correct implementation and avoid
implicit defaults. Also select the necessary I/O helpers in Kconfig.

Fbdev drivers sometimes rely on the callbacks being NULL for a
default implementation to be invoked; hence requiring the I/O
helpers to be built in any case. Setting all callbacks in all
drivers explicitly will allow to make the I/O helpers optional.
This benefits systems that do not use these functions.

No functional changes.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-7-tzimmermann@suse.de

+3
+1
drivers/video/fbdev/Kconfig
··· 289 289 select FB_CFB_FILLRECT 290 290 select FB_CFB_COPYAREA 291 291 select FB_CFB_IMAGEBLIT 292 + select FB_IOMEM_FOPS 292 293 help 293 294 This is the frame buffer device driver for the builtin graphics 294 295 chipset found in Ataris.
+2
drivers/video/fbdev/atafb.c
··· 2665 2665 2666 2666 static struct fb_ops atafb_ops = { 2667 2667 .owner = THIS_MODULE, 2668 + __FB_DEFAULT_IOMEM_OPS_RDWR, 2668 2669 .fb_check_var = atafb_check_var, 2669 2670 .fb_set_par = atafb_set_par, 2670 2671 .fb_blank = atafb_blank, ··· 2674 2673 .fb_copyarea = atafb_copyarea, 2675 2674 .fb_imageblit = atafb_imageblit, 2676 2675 .fb_ioctl = atafb_ioctl, 2676 + __FB_DEFAULT_IOMEM_OPS_MMAP, 2677 2677 }; 2678 2678 2679 2679 static void check_default_par(int detected_mode)