Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

bpf: Fix uninitialized values in BPF_{CORE,PROBE}_READ

With the latest LLVM bpf selftests build will fail with
the following error message:

progs/profiler.inc.h:710:31: error: default initialization of an object of type 'typeof ((parent_task)->real_cred->uid.val)' (aka 'const unsigned int') leaves the object uninitialized and is incompatible with C++ [-Werror,-Wdefault-const-init-unsafe]
710 | proc_exec_data->parent_uid = BPF_CORE_READ(parent_task, real_cred, uid.val);
| ^
tools/testing/selftests/bpf/tools/include/bpf/bpf_core_read.h:520:35: note: expanded from macro 'BPF_CORE_READ'
520 | ___type((src), a, ##__VA_ARGS__) __r; \
| ^

This happens because BPF_CORE_READ (and other macro) declare the
variable __r using the ___type macro which can inherit const modifier
from intermediate types.

Fix this by using __typeof_unqual__, when supported. (And when it
is not supported, the problem shouldn't appear, as older compilers
haven't complained.)

Fixes: 792001f4f7aa ("libbpf: Add user-space variants of BPF_CORE_READ() family of macros")
Fixes: a4b09a9ef945 ("libbpf: Add non-CO-RE variants of BPF_CORE_READ() macro family")
Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20250502193031.3522715-1-a.s.protopopov@gmail.com

authored by

Anton Protopopov and committed by
Andrii Nakryiko
41d4ce6d a28fe316

+6
+6
tools/lib/bpf/bpf_core_read.h
··· 388 388 #define ___arrow10(a, b, c, d, e, f, g, h, i, j) a->b->c->d->e->f->g->h->i->j 389 389 #define ___arrow(...) ___apply(___arrow, ___narg(__VA_ARGS__))(__VA_ARGS__) 390 390 391 + #if defined(__clang__) && (__clang_major__ >= 19) 392 + #define ___type(...) __typeof_unqual__(___arrow(__VA_ARGS__)) 393 + #elif defined(__GNUC__) && (__GNUC__ >= 14) 394 + #define ___type(...) __typeof_unqual__(___arrow(__VA_ARGS__)) 395 + #else 391 396 #define ___type(...) typeof(___arrow(__VA_ARGS__)) 397 + #endif 392 398 393 399 #define ___read(read_fn, dst, src_type, src, accessor) \ 394 400 read_fn((void *)(dst), sizeof(*(dst)), &((src_type)(src))->accessor)