Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

netns: dont alloc ipv6 fib timer list

FIB timer list is a trivial size structure, avoid indirection and just
put it in existing ns.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Stephen Hemminger and committed by
David S. Miller
417f28bb 888c848e

+14 -28
+1 -1
include/net/netns/ipv6.h
··· 39 39 #endif 40 40 struct rt6_info *ip6_null_entry; 41 41 struct rt6_statistics *rt6_stats; 42 - struct timer_list *ip6_fib_timer; 42 + struct timer_list ip6_fib_timer; 43 43 struct hlist_head *fib_table_hash; 44 44 struct fib6_table *fib6_main_tbl; 45 45 struct dst_ops *ip6_dst_ops;
+13 -27
net/ipv6/ip6_fib.c
··· 661 661 662 662 static __inline__ void fib6_start_gc(struct net *net, struct rt6_info *rt) 663 663 { 664 - if (!timer_pending(net->ipv6.ip6_fib_timer) && 664 + if (!timer_pending(&net->ipv6.ip6_fib_timer) && 665 665 (rt->rt6i_flags & (RTF_EXPIRES|RTF_CACHE))) 666 - mod_timer(net->ipv6.ip6_fib_timer, 666 + mod_timer(&net->ipv6.ip6_fib_timer, 667 667 jiffies + net->ipv6.sysctl.ip6_rt_gc_interval); 668 668 } 669 669 670 670 void fib6_force_start_gc(struct net *net) 671 671 { 672 - if (!timer_pending(net->ipv6.ip6_fib_timer)) 673 - mod_timer(net->ipv6.ip6_fib_timer, 672 + if (!timer_pending(&net->ipv6.ip6_fib_timer)) 673 + mod_timer(&net->ipv6.ip6_fib_timer, 674 674 jiffies + net->ipv6.sysctl.ip6_rt_gc_interval); 675 675 } 676 676 ··· 1449 1449 } else { 1450 1450 local_bh_disable(); 1451 1451 if (!spin_trylock(&fib6_gc_lock)) { 1452 - mod_timer(net->ipv6.ip6_fib_timer, jiffies + HZ); 1452 + mod_timer(&net->ipv6.ip6_fib_timer, jiffies + HZ); 1453 1453 local_bh_enable(); 1454 1454 return; 1455 1455 } ··· 1462 1462 fib6_clean_all(net, fib6_age, 0, NULL); 1463 1463 1464 1464 if (gc_args.more) 1465 - mod_timer(net->ipv6.ip6_fib_timer, jiffies + 1465 + mod_timer(&net->ipv6.ip6_fib_timer, jiffies + 1466 1466 net->ipv6.sysctl.ip6_rt_gc_interval); 1467 - else { 1468 - del_timer(net->ipv6.ip6_fib_timer); 1469 - net->ipv6.ip6_fib_timer->expires = 0; 1470 - } 1467 + else 1468 + del_timer(&net->ipv6.ip6_fib_timer); 1471 1469 spin_unlock_bh(&fib6_gc_lock); 1472 1470 } 1473 1471 ··· 1476 1478 1477 1479 static int fib6_net_init(struct net *net) 1478 1480 { 1479 - int ret; 1480 - struct timer_list *timer; 1481 - 1482 - ret = -ENOMEM; 1483 - timer = kzalloc(sizeof(*timer), GFP_KERNEL); 1484 - if (!timer) 1485 - goto out; 1486 - 1487 - setup_timer(timer, fib6_gc_timer_cb, (unsigned long)net); 1488 - net->ipv6.ip6_fib_timer = timer; 1481 + setup_timer(&net->ipv6.ip6_fib_timer, fib6_gc_timer_cb, (unsigned long)net); 1489 1482 1490 1483 net->ipv6.rt6_stats = kzalloc(sizeof(*net->ipv6.rt6_stats), GFP_KERNEL); 1491 1484 if (!net->ipv6.rt6_stats) ··· 1510 1521 #endif 1511 1522 fib6_tables_init(net); 1512 1523 1513 - ret = 0; 1514 - out: 1515 - return ret; 1524 + return 0; 1516 1525 1517 1526 #ifdef CONFIG_IPV6_MULTIPLE_TABLES 1518 1527 out_fib6_main_tbl: ··· 1521 1534 out_rt6_stats: 1522 1535 kfree(net->ipv6.rt6_stats); 1523 1536 out_timer: 1524 - kfree(timer); 1525 - goto out; 1537 + return -ENOMEM; 1526 1538 } 1527 1539 1528 1540 static void fib6_net_exit(struct net *net) 1529 1541 { 1530 1542 rt6_ifdown(net, NULL); 1531 - del_timer_sync(net->ipv6.ip6_fib_timer); 1532 - kfree(net->ipv6.ip6_fib_timer); 1543 + del_timer_sync(&net->ipv6.ip6_fib_timer); 1544 + 1533 1545 #ifdef CONFIG_IPV6_MULTIPLE_TABLES 1534 1546 kfree(net->ipv6.fib6_local_tbl); 1535 1547 #endif