Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/bridge: lvds-codec: Use dev_err_probe for error handling

dev_err_probe function simplifies error handling. So use the same in probe
function wherever possible.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20201020093655.3584-1-biju.das.jz@bp.renesas.com

authored by

Biju Das and committed by
Sam Ravnborg
4178bd5a 281edb9f

+3 -8
+3 -8
drivers/gpu/drm/bridge/lvds-codec.c
··· 80 80 struct device_node *panel_node; 81 81 struct drm_panel *panel; 82 82 struct lvds_codec *lvds_codec; 83 - int ret; 84 83 85 84 lvds_codec = devm_kzalloc(dev, sizeof(*lvds_codec), GFP_KERNEL); 86 85 if (!lvds_codec) ··· 89 90 lvds_codec->connector_type = (uintptr_t)of_device_get_match_data(dev); 90 91 91 92 lvds_codec->vcc = devm_regulator_get(lvds_codec->dev, "power"); 92 - if (IS_ERR(lvds_codec->vcc)) { 93 - ret = PTR_ERR(lvds_codec->vcc); 94 - if (ret != -EPROBE_DEFER) 95 - dev_err(lvds_codec->dev, 96 - "Unable to get \"vcc\" supply: %d\n", ret); 97 - return ret; 98 - } 93 + if (IS_ERR(lvds_codec->vcc)) 94 + return dev_err_probe(dev, PTR_ERR(lvds_codec->vcc), 95 + "Unable to get \"vcc\" supply\n"); 99 96 100 97 lvds_codec->powerdown_gpio = devm_gpiod_get_optional(dev, "powerdown", 101 98 GPIOD_OUT_HIGH);