tjh.dev
Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
Staging: fbtft: fb_pcd8544: Fix comments style
This patch fixes the following errors by refactoring the comments'
style:
WARNING: line over 80 characters
ERROR: code indent should use tabs where possible
Signed-off-by: Cláudio Maia <crrm@isep.ipp.pt>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
authored by
Cláudio Maia
and committed by
Greg Kroah-Hartman
4178549e
14cf23b1
+54
-43
+54
-43
drivers/staging/fbtft/fb_pcd8544.c
+54
-43
drivers/staging/fbtft/fb_pcd8544.c
···
34
34
#define WIDTH 84
35
35
#define HEIGHT 48
36
36
#define TXBUFLEN (84*6)
37
-
#define DEFAULT_GAMMA "40" /* gamma is used to control contrast in this driver */
37
+
#define DEFAULT_GAMMA "40" /* gamma controls the contrast in this driver */
38
38
39
39
static unsigned tc;
40
40
module_param(tc, uint, 0);
···
51
51
52
52
par->fbtftops.reset(par);
53
53
54
-
/* Function set */
55
-
write_reg(par, 0x21); /* 5:1 1
56
-
2:0 PD - Powerdown control: chip is active
57
-
1:0 V - Entry mode: horizontal addressing
58
-
0:1 H - Extended instruction set control: extended
59
-
*/
54
+
/* Function set
55
+
*
56
+
* 5:1 1
57
+
* 2:0 PD - Powerdown control: chip is active
58
+
* 1:0 V - Entry mode: horizontal addressing
59
+
* 0:1 H - Extended instruction set control: extended
60
+
*/
61
+
write_reg(par, 0x21);
60
62
61
-
/* H=1 Temperature control */
62
-
write_reg(par, 0x04 | (tc & 0x3)); /*
63
-
2:1 1
64
-
1:x TC1 - Temperature Coefficient: 0x10
65
-
0:x TC0
66
-
*/
63
+
/* H=1 Temperature control
64
+
*
65
+
* 2:1 1
66
+
* 1:x TC1 - Temperature Coefficient: 0x10
67
+
* 0:x TC0
68
+
*/
69
+
write_reg(par, 0x04 | (tc & 0x3));
67
70
68
-
/* H=1 Bias system */
69
-
write_reg(par, 0x10 | (bs & 0x7)); /*
70
-
4:1 1
71
-
3:0 0
72
-
2:x BS2 - Bias System
73
-
1:x BS1
74
-
0:x BS0
75
-
*/
71
+
/* H=1 Bias system
72
+
*
73
+
* 4:1 1
74
+
* 3:0 0
75
+
* 2:x BS2 - Bias System
76
+
* 1:x BS1
77
+
* 0:x BS0
78
+
*/
79
+
write_reg(par, 0x10 | (bs & 0x7));
76
80
77
-
/* Function set */
78
-
write_reg(par, 0x22); /* 5:1 1
79
-
2:0 PD - Powerdown control: chip is active
80
-
1:1 V - Entry mode: vertical addressing
81
-
0:0 H - Extended instruction set control: basic
82
-
*/
81
+
/* Function set
82
+
*
83
+
* 5:1 1
84
+
* 2:0 PD - Powerdown control: chip is active
85
+
* 1:1 V - Entry mode: vertical addressing
86
+
* 0:0 H - Extended instruction set control: basic
87
+
*/
88
+
write_reg(par, 0x22);
83
89
84
-
/* H=0 Display control */
85
-
write_reg(par, 0x08 | 4); /*
86
-
3:1 1
87
-
2:1 D - DE: 10=normal mode
88
-
1:0 0
89
-
0:0 E
90
-
*/
90
+
/* H=0 Display control
91
+
*
92
+
* 3:1 1
93
+
* 2:1 D - DE: 10=normal mode
94
+
* 1:0 0
95
+
* 0:0 E
96
+
*/
97
+
write_reg(par, 0x08 | 4);
91
98
92
99
return 0;
93
100
}
···
104
97
fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n",
105
98
__func__, xs, ys, xe, ye);
106
99
107
-
/* H=0 Set X address of RAM */
108
-
write_reg(par, 0x80); /* 7:1 1
109
-
6-0: X[6:0] - 0x00
110
-
*/
100
+
/* H=0 Set X address of RAM
101
+
*
102
+
* 7:1 1
103
+
* 6-0: X[6:0] - 0x00
104
+
*/
105
+
write_reg(par, 0x80);
111
106
112
-
/* H=0 Set Y address of RAM */
113
-
write_reg(par, 0x40); /* 7:0 0
114
-
6:1 1
115
-
2-0: Y[2:0] - 0x0
116
-
*/
107
+
/* H=0 Set Y address of RAM
108
+
*
109
+
* 7:0 0
110
+
* 6:1 1
111
+
* 2-0: Y[2:0] - 0x0
112
+
*/
113
+
write_reg(par, 0x40);
117
114
}
118
115
119
116
static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)