net: mscc: ocelot: fix error code in mscc_ocelot_probe()

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

Probe should return an error code if platform_get_irq_byname() fails
but it returns success instead.

Fixes: 6c30384eb1de ("net: mscc: ocelot: register devlink ports")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/YBkXyFIl4V9hgxYM@mwanda
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Dan Carpenter and committed by

Jakub Kicinski 5 years ago 4160d9ec e0c16233

+3 -1

1 changed file

expand all

drivers

net

ethernet

mscc

ocelot_vsc7514.c

+3 -1

drivers/net/ethernet/mscc/ocelot_vsc7514.c

··· 1300 1300 goto out_free_devlink; 1301 1301 1302 1302 irq_xtr = platform_get_irq_byname(pdev, "xtr"); 1303 - if (irq_xtr < 0) 1303 + if (irq_xtr < 0) { 1304 + err = irq_xtr; 1304 1305 goto out_free_devlink; 1306 + } 1305 1307 1306 1308 err = devm_request_threaded_irq(&pdev->dev, irq_xtr, NULL, 1307 1309 ocelot_xtr_irq_handler, IRQF_ONESHOT,