Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mmc: core: Fixup delayed work clock gating patch

c31b50e (mmc: core: Use delayed work in clock gating framework,
2011-11-14) missed a few things during review:

o A useless pr_info()

o milliseconds was written as two words

o The sysfs file had units in its output

Fix all three problems.

Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Cc: Sujit Reddy Thumma <sthumma@codeaurora.org>
Signed-off-by: Chris Ball <cjb@laptop.org>

authored by

Stephen Boyd and committed by
Chris Ball
4137e504 b678b91f

+2 -6
+1 -1
Documentation/mmc/mmc-dev-attrs.txt
··· 71 71 Read and write access is provided to following attribute. 72 72 This attribute appears only if CONFIG_MMC_CLKGATE is enabled. 73 73 74 - clkgate_delay Tune the clock gating delay with desired value in milli seconds. 74 + clkgate_delay Tune the clock gating delay with desired value in milliseconds. 75 75 76 76 echo <desired delay> > /sys/class/mmc_host/mmcX/clkgate_delay
+1 -5
drivers/mmc/core/host.c
··· 58 58 struct device_attribute *attr, char *buf) 59 59 { 60 60 struct mmc_host *host = cls_dev_to_mmc_host(dev); 61 - return snprintf(buf, PAGE_SIZE, "%lu millisecs\n", 62 - host->clkgate_delay); 61 + return snprintf(buf, PAGE_SIZE, "%lu\n", host->clkgate_delay); 63 62 } 64 63 65 64 static ssize_t clkgate_delay_store(struct device *dev, ··· 73 74 spin_lock_irqsave(&host->clk_lock, flags); 74 75 host->clkgate_delay = value; 75 76 spin_unlock_irqrestore(&host->clk_lock, flags); 76 - 77 - pr_info("%s: clock gate delay set to %lu ms\n", 78 - mmc_hostname(host), value); 79 77 return count; 80 78 } 81 79