Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

HID: pantherlord: validate output report details

A HID device could send a malicious output report that would cause the
pantherlord HID driver to write beyond the output report allocation
during initialization, causing a heap overflow:

[ 310.939483] usb 1-1: New USB device found, idVendor=0e8f, idProduct=0003
...
[ 315.980774] BUG kmalloc-192 (Tainted: G W ): Redzone overwritten

CVE-2013-2892

Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: stable@kernel.org
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

authored by

Kees Cook and committed by
Jiri Kosina
412f3010 8c89cc17

+8 -2
+8 -2
drivers/hid/hid-pl.c
··· 132 132 strong = &report->field[0]->value[2]; 133 133 weak = &report->field[0]->value[3]; 134 134 debug("detected single-field device"); 135 - } else if (report->maxfield >= 4 && report->field[0]->maxusage == 1 && 136 - report->field[0]->usage[0].hid == (HID_UP_LED | 0x43)) { 135 + } else if (report->field[0]->maxusage == 1 && 136 + report->field[0]->usage[0].hid == 137 + (HID_UP_LED | 0x43) && 138 + report->maxfield >= 4 && 139 + report->field[0]->report_count >= 1 && 140 + report->field[1]->report_count >= 1 && 141 + report->field[2]->report_count >= 1 && 142 + report->field[3]->report_count >= 1) { 137 143 report->field[0]->value[0] = 0x00; 138 144 report->field[1]->value[0] = 0x00; 139 145 strong = &report->field[2]->value[0];