net: lan966x: fix checking for return value of platform_get_irq_byname()

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

The platform_get_irq_byname() returns non-zero IRQ number
or negative error number. "if (irq)" always true, chang it
to "if (irq > 0)"

Signed-off-by: Li Qiong <liqiong@nfschina.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Li Qiong and committed by

David S. Miller 3 years ago 40b4ac88 75d8620d

+4 -4

1 changed file

expand all

drivers

net

ethernet

microchip

lan966x

lan966x_main.c

+4 -4

drivers/net/ethernet/microchip/lan966x/lan966x_main.c

··· 710 710 disable_irq(lan966x->xtr_irq); 711 711 lan966x->xtr_irq = -ENXIO; 712 712 713 - if (lan966x->ana_irq) { 713 + if (lan966x->ana_irq > 0) { 714 714 disable_irq(lan966x->ana_irq); 715 715 lan966x->ana_irq = -ENXIO; 716 716 } ··· 718 718 if (lan966x->fdma) 719 719 devm_free_irq(lan966x->dev, lan966x->fdma_irq, lan966x); 720 720 721 - if (lan966x->ptp_irq) 721 + if (lan966x->ptp_irq > 0) 722 722 devm_free_irq(lan966x->dev, lan966x->ptp_irq, lan966x); 723 723 724 - if (lan966x->ptp_ext_irq) 724 + if (lan966x->ptp_ext_irq > 0) 725 725 devm_free_irq(lan966x->dev, lan966x->ptp_ext_irq, lan966x); 726 726 } 727 727 ··· 1049 1049 } 1050 1050 1051 1051 lan966x->ana_irq = platform_get_irq_byname(pdev, "ana"); 1052 - if (lan966x->ana_irq) { 1052 + if (lan966x->ana_irq > 0) { 1053 1053 err = devm_request_threaded_irq(&pdev->dev, lan966x->ana_irq, NULL, 1054 1054 lan966x_ana_irq_handler, IRQF_ONESHOT, 1055 1055 "ana irq", lan966x);