Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: ethernet: litex: Fix return type of liteeth_start_xmit

The ndo_start_xmit field in net_device_ops is expected to be of type
netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of liteeth_start_xmit should be changed from int to
netdev_tx_t.

Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Gabriel Somlo <gsomlo@gmail.com>
Link: https://lore.kernel.org/r/20220912195307.812229-1-nhuck@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Nathan Huckleberry and committed by
Jakub Kicinski
40662333 5972ca94

+2 -1
+2 -1
drivers/net/ethernet/litex/litex_liteeth.c
··· 152 152 return 0; 153 153 } 154 154 155 - static int liteeth_start_xmit(struct sk_buff *skb, struct net_device *netdev) 155 + static netdev_tx_t liteeth_start_xmit(struct sk_buff *skb, 156 + struct net_device *netdev) 156 157 { 157 158 struct liteeth *priv = netdev_priv(netdev); 158 159 void __iomem *txbuffer;