hwmon: (k10temp) Fix reading critical temperature register

The HTC (Hardware Temperature Control) register has moved
for recent chips.

Cc: stable@vger.kernel.org # v4.16+
Tested-by: Gabriel Craciunescu <nix.or.die@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

+30 -10
+30 -10
drivers/hwmon/k10temp.c
··· 63 63 #define NB_CAP_HTC 0x00000400 64 64 65 65 /* 66 - * For F15h M60h, functionality of REG_REPORTED_TEMPERATURE 67 - * has been moved to D0F0xBC_xD820_0CA4 [Reported Temperature 68 - * Control] 66 + * For F15h M60h and M70h, REG_HARDWARE_THERMAL_CONTROL 67 + * and REG_REPORTED_TEMPERATURE have been moved to 68 + * D0F0xBC_xD820_0C64 [Hardware Temperature Control] 69 + * D0F0xBC_xD820_0CA4 [Reported Temperature Control] 69 70 */ 71 + #define F15H_M60H_HARDWARE_TEMP_CTRL_OFFSET 0xd8200c64 70 72 #define F15H_M60H_REPORTED_TEMP_CTRL_OFFSET 0xd8200ca4 71 73 72 74 /* F17h M01h Access througn SMN */ ··· 76 74 77 75 struct k10temp_data { 78 76 struct pci_dev *pdev; 77 + void (*read_htcreg)(struct pci_dev *pdev, u32 *regval); 79 78 void (*read_tempreg)(struct pci_dev *pdev, u32 *regval); 80 79 int temp_offset; 81 80 u32 temp_adjust_mask; ··· 101 98 { 0x17, "AMD Ryzen Threadripper 1910", 10000 }, 102 99 }; 103 100 101 + static void read_htcreg_pci(struct pci_dev *pdev, u32 *regval) 102 + { 103 + pci_read_config_dword(pdev, REG_HARDWARE_THERMAL_CONTROL, regval); 104 + } 105 + 104 106 static void read_tempreg_pci(struct pci_dev *pdev, u32 *regval) 105 107 { 106 108 pci_read_config_dword(pdev, REG_REPORTED_TEMPERATURE, regval); ··· 120 112 pci_bus_read_config_dword(pdev->bus, devfn, 121 113 base + 4, val); 122 114 mutex_unlock(&nb_smu_ind_mutex); 115 + } 116 + 117 + static void read_htcreg_nb_f15(struct pci_dev *pdev, u32 *regval) 118 + { 119 + amd_nb_index_read(pdev, PCI_DEVFN(0, 0), 0xb8, 120 + F15H_M60H_HARDWARE_TEMP_CTRL_OFFSET, regval); 123 121 } 124 122 125 123 static void read_tempreg_nb_f15(struct pci_dev *pdev, u32 *regval) ··· 174 160 u32 regval; 175 161 int value; 176 162 177 - pci_read_config_dword(data->pdev, 178 - REG_HARDWARE_THERMAL_CONTROL, &regval); 163 + data->read_htcreg(data->pdev, &regval); 179 164 value = ((regval >> 16) & 0x7f) * 500 + 52000; 180 165 if (show_hyst) 181 166 value -= ((regval >> 24) & 0xf) * 500; ··· 194 181 struct pci_dev *pdev = data->pdev; 195 182 196 183 if (index >= 2) { 197 - u32 reg_caps, reg_htc; 184 + u32 reg; 185 + 186 + if (!data->read_htcreg) 187 + return 0; 198 188 199 189 pci_read_config_dword(pdev, REG_NORTHBRIDGE_CAPABILITIES, 200 - &reg_caps); 201 - pci_read_config_dword(pdev, REG_HARDWARE_THERMAL_CONTROL, 202 - &reg_htc); 203 - if (!(reg_caps & NB_CAP_HTC) || !(reg_htc & HTC_ENABLE)) 190 + &reg); 191 + if (!(reg & NB_CAP_HTC)) 192 + return 0; 193 + 194 + data->read_htcreg(data->pdev, &reg); 195 + if (!(reg & HTC_ENABLE)) 204 196 return 0; 205 197 } 206 198 return attr->mode; ··· 286 268 287 269 if (boot_cpu_data.x86 == 0x15 && (boot_cpu_data.x86_model == 0x60 || 288 270 boot_cpu_data.x86_model == 0x70)) { 271 + data->read_htcreg = read_htcreg_nb_f15; 289 272 data->read_tempreg = read_tempreg_nb_f15; 290 273 } else if (boot_cpu_data.x86 == 0x17) { 291 274 data->temp_adjust_mask = 0x80000; 292 275 data->read_tempreg = read_tempreg_nb_f17; 293 276 } else { 277 + data->read_htcreg = read_htcreg_pci; 294 278 data->read_tempreg = read_tempreg_pci; 295 279 } 296 280