Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

IB/rdmavt: Validate remote_addr during loopback atomic tests

The rdma-core test suite sends an unaligned remote address and expects a
failure.

ERROR: test_atomic_non_aligned_addr (tests.test_atomic.AtomicTest)

The qib/hfi1 rc handling validates properly, but the test has the client
and server on the same system.

The loopback of these operations is a distinct code path.

Fix by syntaxing the proposed remote address in the loopback code path.

Fixes: 15703461533a ("IB/{hfi1, qib, rdmavt}: Move ruc_loopback to rdmavt")
Link: https://lore.kernel.org/r/1642584489-141005-1-git-send-email-mike.marciniszyn@cornelisnetworks.com
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Signed-off-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

authored by

Mike Marciniszyn and committed by
Jason Gunthorpe
4028bccb b856101a

+2
+2
drivers/infiniband/sw/rdmavt/qp.c
··· 3073 3073 case IB_WR_ATOMIC_FETCH_AND_ADD: 3074 3074 if (unlikely(!(qp->qp_access_flags & IB_ACCESS_REMOTE_ATOMIC))) 3075 3075 goto inv_err; 3076 + if (unlikely(wqe->atomic_wr.remote_addr & (sizeof(u64) - 1))) 3077 + goto inv_err; 3076 3078 if (unlikely(!rvt_rkey_ok(qp, &qp->r_sge.sge, sizeof(u64), 3077 3079 wqe->atomic_wr.remote_addr, 3078 3080 wqe->atomic_wr.rkey,