Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
tjh.dev
kernel
os
linux
sh: Fix up uninitialized variable use caught by gcc 4.4.
In the unaligned kernel exception fixup case the printk() was ordered
before the copy_from_user(), resulting in a nonsensical instruction
value. This fixes up the ordering properly.
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
+6
-6
arch/sh/kernel/traps_32.c
+6
-6
arch/sh/kernel/traps_32.c
···
678
} else {
679
se_sys += 1;
680
681
-
if (se_kernmode_warn)
682
-
printk(KERN_NOTICE "Unaligned kernel access "
683
-
"on behalf of \"%s\" pid=%d pc=0x%p ins=0x%04hx\n",
684
-
current->comm, current->pid, (void *)regs->pc,
685
-
instruction);
686
-
687
if (regs->pc & 1)
688
die("unaligned program counter", regs, error_code);
689
···
690
set_fs(oldfs);
691
die("insn faulting in do_address_error", regs, 0);
692
}
693
694
handle_unaligned_access(instruction, regs,
695
&user_mem_access, 0);
···
678
} else {
679
se_sys += 1;
680
681
if (regs->pc & 1)
682
die("unaligned program counter", regs, error_code);
683
···
696
set_fs(oldfs);
697
die("insn faulting in do_address_error", regs, 0);
698
}
699
+
700
+
if (se_kernmode_warn)
701
+
printk(KERN_NOTICE "Unaligned kernel access "
702
+
"on behalf of \"%s\" pid=%d pc=0x%p ins=0x%04hx\n",
703
+
current->comm, current->pid, (void *)regs->pc,
704
+
instruction);
705
706
handle_unaligned_access(instruction, regs,
707
&user_mem_access, 0);