Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

power: supply: bq27xxx: Simplify with dev_err_probe()

Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

authored by

Krzysztof Kozlowski and committed by
Sebastian Reichel
4024810c 5ca937fb

+3 -7
+3 -7
drivers/power/supply/bq27xxx_battery.c
··· 1992 1992 psy_desc->external_power_changed = bq27xxx_external_power_changed; 1993 1993 1994 1994 di->bat = power_supply_register_no_ws(di->dev, psy_desc, &psy_cfg); 1995 - if (IS_ERR(di->bat)) { 1996 - if (PTR_ERR(di->bat) == -EPROBE_DEFER) 1997 - dev_dbg(di->dev, "failed to register battery, deferring probe\n"); 1998 - else 1999 - dev_err(di->dev, "failed to register battery\n"); 2000 - return PTR_ERR(di->bat); 2001 - } 1995 + if (IS_ERR(di->bat)) 1996 + return dev_err_probe(di->dev, PTR_ERR(di->bat), 1997 + "failed to register battery\n"); 2002 1998 2003 1999 bq27xxx_battery_settings(di); 2004 2000 bq27xxx_battery_update(di);