Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers/rtc/rtc-pcf8563.c: fix pcf8563_irq() error return value

As pointed out by Sergei Shtylyov, the pcf8563_irq function contains a
bug in the error handling: an interrupt handler is not supposed to
return an errno value but an 'enum irqreturn'.

Let's fix this by returning IRQ_NONE in case of a communication error.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Arnd Bergmann and committed by
Linus Torvalds
3ff38237 e698a512

+1 -1
+1 -1
drivers/rtc/rtc-pcf8563.c
··· 168 168 169 169 err = pcf8563_get_alarm_mode(pcf8563->client, NULL, &pending); 170 170 if (err) 171 - return err; 171 + return IRQ_NONE; 172 172 173 173 if (pending) { 174 174 rtc_update_irq(pcf8563->rtc, 1, RTC_IRQF | RTC_AF);