Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

crypto: tegra - Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Fixes: 0880bb3b00c8 ("crypto: tegra - Add Tegra Security Engine driver")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Akhil R <akhilrajeev@nvidia.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Uwe Kleine-König and committed by
Herbert Xu
3f4d1482 543ea178

+2 -4
+2 -4
drivers/crypto/tegra/tegra-se-main.c
··· 320 320 return 0; 321 321 } 322 322 323 - static int tegra_se_remove(struct platform_device *pdev) 323 + static void tegra_se_remove(struct platform_device *pdev) 324 324 { 325 325 struct tegra_se *se = platform_get_drvdata(pdev); 326 326 ··· 328 328 crypto_engine_exit(se->engine); 329 329 iommu_fwspec_free(se->dev); 330 330 host1x_client_unregister(&se->client); 331 - 332 - return 0; 333 331 } 334 332 335 333 static const struct tegra_se_regs tegra234_aes1_regs = { ··· 388 390 .of_match_table = tegra_se_of_match, 389 391 }, 390 392 .probe = tegra_se_probe, 391 - .remove = tegra_se_remove, 393 + .remove_new = tegra_se_remove, 392 394 }; 393 395 394 396 static int tegra_se_host1x_probe(struct host1x_device *dev)