Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

irqchip/loongson-htpic: Fix build warnings

Fix build warnings as below:

drivers/irqchip/irq-loongson-htpic.c: In function 'htpic_reg_init':
>> drivers/irqchip/irq-loongson-htpic.c:62:12: warning: variable 'val' set but not used [-Wunused-but-set-variable]
62 | uint32_t val;
| ^~~
drivers/irqchip/irq-loongson-htpic.c: At top level:
>> drivers/irqchip/irq-loongson-htpic.c:84:12: warning: no previous prototype for 'htpic_of_init' [-Wmissing-prototypes]
84 | int __init htpic_of_init(struct device_node *node, struct device_node *parent)
| ^~~~~~~~~~~~~

Fixes: a93f1d903fa34fc2c5d9fa450bd ("irqchip: Add driver for Loongson-3 HyperTransport PIC controller")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Huacai Chen <chenhuacai@kernel.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/1607159744-995-1-git-send-email-chenhuacai@kernel.org

authored by

Huacai Chen and committed by
Marc Zyngier
3ee36352 42a590b0

+3 -4
+3 -4
drivers/irqchip/irq-loongson-htpic.c
··· 59 59 int i; 60 60 61 61 for (i = 0; i < HTINT_NUM_VECTORS; i++) { 62 - uint32_t val; 63 - 64 62 /* Disable all HT Vectors */ 65 63 writel(0x0, htpic->base + HTINT_EN_OFF + i * 0x4); 66 - val = readl(htpic->base + i * 0x4); 64 + /* Read back to force write */ 65 + (void) readl(htpic->base + i * 0x4); 67 66 /* Ack all possible pending IRQs */ 68 67 writel(GENMASK(31, 0), htpic->base + i * 0x4); 69 68 } ··· 80 81 .resume = htpic_resume, 81 82 }; 82 83 83 - int __init htpic_of_init(struct device_node *node, struct device_node *parent) 84 + static int __init htpic_of_init(struct device_node *node, struct device_node *parent) 84 85 { 85 86 unsigned int parent_irq[4]; 86 87 int i, err;