Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mmc: sunplus-mmc: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
Link: https://lore.kernel.org/r/20230727070051.17778-49-frank.li@vivo.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

authored by

Yangtao Li and committed by
Ulf Hansson
3ed9c648 bd0e512b

+2 -4
+2 -4
drivers/mmc/host/sunplus-mmc.c
··· 939 939 return ret; 940 940 } 941 941 942 - static int spmmc_drv_remove(struct platform_device *dev) 942 + static void spmmc_drv_remove(struct platform_device *dev) 943 943 { 944 944 struct spmmc_host *host = platform_get_drvdata(dev); 945 945 ··· 948 948 clk_disable_unprepare(host->clk); 949 949 pm_runtime_put_noidle(&dev->dev); 950 950 pm_runtime_disable(&dev->dev); 951 - 952 - return 0; 953 951 } 954 952 955 953 static int spmmc_pm_runtime_suspend(struct device *dev) ··· 982 984 983 985 static struct platform_driver spmmc_driver = { 984 986 .probe = spmmc_drv_probe, 985 - .remove = spmmc_drv_remove, 987 + .remove_new = spmmc_drv_remove, 986 988 .driver = { 987 989 .name = "spmmc", 988 990 .pm = pm_ptr(&spmmc_pm_ops),