Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

thermal/drivers/tsens: Fix compilation warnings by making functions static

After merging tsens-common.c into tsens.c, we can now mark some
functions static so they don't need any prototype declarations. This
fixes the following issue reported by lkp.

>> drivers/thermal/qcom/tsens.c:385:13: warning: no previous prototype for 'tsens_critical_irq_thread' [-Wmissing-prototypes]
385 | irqreturn_t tsens_critical_irq_thread(int irq, void *data)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/thermal/qcom/tsens.c:455:13: warning: no previous prototype for 'tsens_irq_thread' [-Wmissing-prototypes]
455 | irqreturn_t tsens_irq_thread(int irq, void *data)
| ^~~~~~~~~~~~~~~~
>> drivers/thermal/qcom/tsens.c:523:5: warning: no previous prototype for 'tsens_set_trips' [-Wmissing-prototypes]
523 | int tsens_set_trips(void *_sensor, int low, int high)
| ^~~~~~~~~~~~~~~
>> drivers/thermal/qcom/tsens.c:560:5: warning: no previous prototype for 'tsens_enable_irq' [-Wmissing-prototypes]
560 | int tsens_enable_irq(struct tsens_priv *priv)
| ^~~~~~~~~~~~~~~~
>> drivers/thermal/qcom/tsens.c:573:6: warning: no previous prototype for 'tsens_disable_irq' [-Wmissing-prototypes]
573 | void tsens_disable_irq(struct tsens_priv *priv)
| ^~~~~~~~~~~~~~~~~

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/6757a26876b29922929abf64b1c11fa3b3033d03.1590579709.git.amit.kucheria@linaro.org

authored by

Amit Kucheria and committed by
Daniel Lezcano
3ecc8292 b4147917

+5 -5
+5 -5
drivers/thermal/qcom/tsens.c
··· 382 382 * 383 383 * Return: IRQ_HANDLED 384 384 */ 385 - irqreturn_t tsens_critical_irq_thread(int irq, void *data) 385 + static irqreturn_t tsens_critical_irq_thread(int irq, void *data) 386 386 { 387 387 struct tsens_priv *priv = data; 388 388 struct tsens_irq_data d; ··· 452 452 * 453 453 * Return: IRQ_HANDLED 454 454 */ 455 - irqreturn_t tsens_irq_thread(int irq, void *data) 455 + static irqreturn_t tsens_irq_thread(int irq, void *data) 456 456 { 457 457 struct tsens_priv *priv = data; 458 458 struct tsens_irq_data d; ··· 520 520 return IRQ_HANDLED; 521 521 } 522 522 523 - int tsens_set_trips(void *_sensor, int low, int high) 523 + static int tsens_set_trips(void *_sensor, int low, int high) 524 524 { 525 525 struct tsens_sensor *s = _sensor; 526 526 struct tsens_priv *priv = s->priv; ··· 557 557 return 0; 558 558 } 559 559 560 - int tsens_enable_irq(struct tsens_priv *priv) 560 + static int tsens_enable_irq(struct tsens_priv *priv) 561 561 { 562 562 int ret; 563 563 int val = tsens_version(priv) > VER_1_X ? 7 : 1; ··· 570 570 return ret; 571 571 } 572 572 573 - void tsens_disable_irq(struct tsens_priv *priv) 573 + static void tsens_disable_irq(struct tsens_priv *priv) 574 574 { 575 575 regmap_field_write(priv->rf[INT_EN], 0); 576 576 }