Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwmon: (i5500_temp) use permission-specific DEVICE_ATTR variants

Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.

The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

authored by

Julia Lawall and committed by
Guenter Roeck
3eb52cfd 2ab0c6c5

+3 -3
+3 -3
drivers/hwmon/i5500_temp.c
··· 43 43 */ 44 44 45 45 /* Sensor resolution : 0.5 degree C */ 46 - static ssize_t show_temp(struct device *dev, 47 - struct device_attribute *devattr, char *buf) 46 + static ssize_t temp1_input_show(struct device *dev, 47 + struct device_attribute *devattr, char *buf) 48 48 { 49 49 struct pci_dev *pdev = to_pci_dev(dev->parent); 50 50 long temp; ··· 83 83 return sprintf(buf, "%u\n", (unsigned int)ctsts & (1 << nr)); 84 84 } 85 85 86 - static DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL); 86 + static DEVICE_ATTR_RO(temp1_input); 87 87 static SENSOR_DEVICE_ATTR(temp1_crit, S_IRUGO, show_thresh, NULL, 0xE2); 88 88 static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IRUGO, show_thresh, NULL, 0xEC); 89 89 static SENSOR_DEVICE_ATTR(temp1_max, S_IRUGO, show_thresh, NULL, 0xEE);