Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

phy: samsung: Merge Kconfig for Exynos5420 and Exynos5250

Exynos5420 variant of USB2 PHY is handled by the same code as the
Exynos5250 one. Introducing a separate Kconfig symbol for it was an
over-engineering, which turned out to cause build break for certain
configurations:

ERROR: modpost: "exynos5420_usb2_phy_config" [drivers/phy/samsung/phy-exynos-usb2.ko] undefined!

Fix this by removing PHY_EXYNOS5420_USB2 symbol and using
PHY_EXYNOS5250_USB2 also for Exynos5420 SoCs.

Reported-by: Markus Reichl <m.reichl@fivetechno.de>
Fixes: 81b534f7e9b2 ("phy: samsung: Add support for the Exynos5420 variant of the USB2 PHY")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Link: https://lore.kernel.org/r/20201202064759.24300-1-m.szyprowski@samsung.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Marek Szyprowski and committed by
Vinod Koul
3eaf2da9 8145dcb0

+1 -8
+1 -6
drivers/phy/samsung/Kconfig
··· 64 64 config PHY_EXYNOS5250_USB2 65 65 bool 66 66 depends on PHY_SAMSUNG_USB2 67 - default SOC_EXYNOS5250 68 - 69 - config PHY_EXYNOS5420_USB2 70 - bool 71 - depends on PHY_SAMSUNG_USB2 72 - default SOC_EXYNOS5420 67 + default SOC_EXYNOS5250 || SOC_EXYNOS5420 73 68 74 69 config PHY_S5PV210_USB2 75 70 bool "Support for S5PV210"
-2
drivers/phy/samsung/phy-samsung-usb2.c
··· 127 127 .compatible = "samsung,exynos5250-usb2-phy", 128 128 .data = &exynos5250_usb2_phy_config, 129 129 }, 130 - #endif 131 - #ifdef CONFIG_PHY_EXYNOS5420_USB2 132 130 { 133 131 .compatible = "samsung,exynos5420-usb2-phy", 134 132 .data = &exynos5420_usb2_phy_config,