Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: typec: qcom-pmic-typec: Switch to use dev_err_probe() helper

In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20220922135708.2212249-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Yang Yingliang and committed by
Greg Kroah-Hartman
3eab90ae 759fcaaf

+2 -3
+2 -3
drivers/usb/typec/qcom-pmic-typec.c
··· 195 195 196 196 qcom_usb->role_sw = fwnode_usb_role_switch_get(dev_fwnode(qcom_usb->dev)); 197 197 if (IS_ERR(qcom_usb->role_sw)) { 198 - if (PTR_ERR(qcom_usb->role_sw) != -EPROBE_DEFER) 199 - dev_err(dev, "failed to get role switch\n"); 200 - ret = PTR_ERR(qcom_usb->role_sw); 198 + ret = dev_err_probe(dev, PTR_ERR(qcom_usb->role_sw), 199 + "failed to get role switch\n"); 201 200 goto err_typec_port; 202 201 } 203 202