Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork

Configure Feed

Select the types of activity you want to include in your feed.

x86/alternatives: Sync core before enabling interrupts

text_poke_early() does:

local_irq_save(flags);
memcpy(addr, opcode, len);
local_irq_restore(flags);
sync_core();

That's not really correct because the synchronization should happen before
interrupts are re-enabled to ensure that a pending interrupt observes the
complete update of the opcodes.

It's not entirely clear whether the interrupt entry provides enough
serialization already, but moving the sync_core() invocation into interrupt
disabled region does no harm and is obviously correct.

Fixes: 6fffacb30349 ("x86/alternatives, jumplabel: Use text_poke_early() before mm_init()")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: <stable@kernel.org>
Link: https://lore.kernel.org/r/ZT6narvE%2BLxX%2B7Be@windriver.com

authored by

Thomas Gleixner and committed by
Borislav Petkov (AMD)
3ea1704a 69a7386c

+1 -1
+1 -1
arch/x86/kernel/alternative.c
··· 1685 1685 } else { 1686 1686 local_irq_save(flags); 1687 1687 memcpy(addr, opcode, len); 1688 - local_irq_restore(flags); 1689 1688 sync_core(); 1689 + local_irq_restore(flags); 1690 1690 1691 1691 /* 1692 1692 * Could also do a CLFLUSH here to speed up CPU recovery; but