Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ubifs: Only check replay with inode type to judge if inode linked

Conside the following case, it just write a big file into flash,
when complete writing, delete the file, and then power off promptly.
Next time power on, we'll get a replay list like:
...
LEB 1105:211344 len 4144 deletion 0 sqnum 428783 key type 1 inode 80
LEB 15:233544 len 160 deletion 1 sqnum 428785 key type 0 inode 80
LEB 1105:215488 len 4144 deletion 0 sqnum 428787 key type 1 inode 80
...
In the replay list, data nodes' deletion are 0, and the inode node's
deletion is 1. In current logic, the file's dentry will be removed,
but inode and the flash space it occupied will be reserved.
User will see that much free space been disappeared.

We only need to check the deletion value of the following inode type
node of the replay entry.

Fixes: e58725d51fa8 ("ubifs: Handle re-linking of inodes correctly while recovery")
Cc: stable@vger.kernel.org
Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
Signed-off-by: Richard Weinberger <richard@nod.at>

authored by

Guochun Mao and committed by
Richard Weinberger
3e903315 d434405a

+2 -1
+2 -1
fs/ubifs/replay.c
··· 223 223 */ 224 224 list_for_each_entry_reverse(r, &c->replay_list, list) { 225 225 ubifs_assert(c, r->sqnum >= rino->sqnum); 226 - if (key_inum(c, &r->key) == key_inum(c, &rino->key)) 226 + if (key_inum(c, &r->key) == key_inum(c, &rino->key) && 227 + key_type(c, &r->key) == UBIFS_INO_KEY) 227 228 return r->deletion == 0; 228 229 229 230 }