phylib: fix premature freeing of struct mii_bus

Commit 46abc02175b3c246dd5141d878f565a8725060c9 ("phylib: give mdio
buses a device tree presence") added a call to device_unregister() in
a situation where the caller did not intend for the device to be
freed yet, but apart from just unregistering the device from the
system, device_unregister() does an additional put_device() that is
intended to free it.

The right function to use in this situation is device_del(), which
unregisters the device from the system like device_unregister() does,
but without dropping the reference count an additional time.

Bug report from Bryan Wu <cooloney@kernel.org>.

Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Tested-by: Bryan Wu <cooloney@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

authored by Lennert Buytenhek and committed by Jeff Garzik 3e44017b 3b259e36

+1 -1
+1 -1
drivers/net/phy/mdio_bus.c
··· 136 136 BUG_ON(bus->state != MDIOBUS_REGISTERED); 137 137 bus->state = MDIOBUS_UNREGISTERED; 138 138 139 - device_unregister(&bus->dev); 139 + device_del(&bus->dev); 140 140 for (i = 0; i < PHY_MAX_ADDR; i++) { 141 141 if (bus->phy_map[i]) 142 142 device_unregister(&bus->phy_map[i]->dev);