Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

sh: Kill off set_irq_flags usage

set_irq_flags is ARM specific with custom flags which have genirq
equivalents. Convert drivers to use the genirq interfaces directly, so we
can kill off set_irq_flags. The translation of flags is as follows:

IRQF_VALID -> !IRQ_NOREQUEST
IRQF_PROBE -> !IRQ_NOPROBE
IRQF_NOAUTOEN -> IRQ_NOAUTOEN

For IRQs managed by an irqdomain, the irqdomain core code handles clearing
and setting IRQ_NOREQUEST already, so there is no need to do this in
.map() functions and we can simply remove the set_irq_flags calls. Some
users also modify IRQ_NOPROBE and this has been maintained although it
is not clear that is really needed. There appears to be a great deal of
blind copy and paste of this code.

Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Simon Horman <horms@verge.net.au>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-sh@vger.kernel.org
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Magnus Damm <magnus.damm@gmail.com>
Link: http://lkml.kernel.org/r/1440889285-5637-4-git-send-email-robh@kernel.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

authored by

Rob Herring and committed by
Thomas Gleixner
3e15135b d17cab44

+1 -9
+1 -9
drivers/sh/intc/internals.h
··· 99 99 */ 100 100 static inline void activate_irq(int irq) 101 101 { 102 - #ifdef CONFIG_ARM 103 - /* ARM requires an extra step to clear IRQ_NOREQUEST, which it 104 - * sets on behalf of every irq_chip. Also sets IRQ_NOPROBE. 105 - */ 106 - set_irq_flags(irq, IRQF_VALID); 107 - #else 108 - /* same effect on other architectures */ 109 - irq_set_noprobe(irq); 110 - #endif 102 + irq_modify_status(irq, IRQ_NOREQUEST, IRQ_NOPROBE); 111 103 } 112 104 113 105 static inline int intc_handle_int_cmp(const void *a, const void *b)