Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drbd: drop wrong debugging aid

The textual representation of resync extents in /proc/drbd presented
with proc_details >= 3 was wrong, it used bitnumbers as bitmasks.

It was not particularly useful either, and I doubt anyone has even tried
to look at it in the last few years. Drop it.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

authored by

Lars Ellenberg and committed by
Philipp Reisner
3e0c78d3 4dd726f0

-17
-17
drivers/block/drbd/drbd_proc.c
··· 188 188 } 189 189 } 190 190 191 - static void resync_dump_detail(struct seq_file *seq, struct lc_element *e) 192 - { 193 - struct bm_extent *bme = lc_entry(e, struct bm_extent, lce); 194 - 195 - seq_printf(seq, "%5d %s %s\n", bme->rs_left, 196 - bme->flags & BME_NO_WRITES ? "NO_WRITES" : "---------", 197 - bme->flags & BME_LOCKED ? "LOCKED" : "------" 198 - ); 199 - } 200 - 201 191 static int drbd_seq_show(struct seq_file *seq, void *v) 202 192 { 203 193 int i, prev_i = -1; ··· 287 297 lc_seq_printf_stats(seq, device->resync); 288 298 lc_seq_printf_stats(seq, device->act_log); 289 299 put_ldev(device); 290 - } 291 - 292 - if (proc_details >= 2) { 293 - if (device->resync) { 294 - lc_seq_dump_details(seq, device->resync, "rs_left", 295 - resync_dump_detail); 296 - } 297 300 } 298 301 } 299 302 rcu_read_unlock();