Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

orangefs: Remove unused type in macro fill_default_sys_attrs

Remove the unused type parameter from the macro definition and all its
callers, making the interface consistent with its actual usage.

Fixes: 69a23de2f3de ("orangefs: clean up fill_default_sys_attrs")
Signed-off-by: Zhen Ni <zhen.ni@easystack.cn>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>

authored by

Zhen Ni and committed by
Mike Marshall
3dffadfa f83ec76b

+4 -8
+3 -7
fs/orangefs/namei.c
··· 38 38 39 39 new_op->upcall.req.create.parent_refn = parent->refn; 40 40 41 - fill_default_sys_attrs(new_op->upcall.req.create.attributes, 42 - ORANGEFS_TYPE_METAFILE, mode); 41 + fill_default_sys_attrs(new_op->upcall.req.create.attributes, mode); 43 42 44 43 strscpy(new_op->upcall.req.create.d_name, dentry->d_name.name); 45 44 ··· 239 240 240 241 new_op->upcall.req.sym.parent_refn = parent->refn; 241 242 242 - fill_default_sys_attrs(new_op->upcall.req.sym.attributes, 243 - ORANGEFS_TYPE_SYMLINK, 244 - mode); 243 + fill_default_sys_attrs(new_op->upcall.req.sym.attributes, mode); 245 244 246 245 strscpy(new_op->upcall.req.sym.entry_name, dentry->d_name.name); 247 246 strscpy(new_op->upcall.req.sym.target, symname); ··· 313 316 314 317 new_op->upcall.req.mkdir.parent_refn = parent->refn; 315 318 316 - fill_default_sys_attrs(new_op->upcall.req.mkdir.attributes, 317 - ORANGEFS_TYPE_DIRECTORY, mode); 319 + fill_default_sys_attrs(new_op->upcall.req.mkdir.attributes, mode); 318 320 319 321 strscpy(new_op->upcall.req.mkdir.d_name, dentry->d_name.name); 320 322
+1 -1
fs/orangefs/orangefs-kernel.h
··· 462 462 ((ORANGEFS_SB(inode->i_sb)->flags & ORANGEFS_OPT_INTR) ? \ 463 463 ORANGEFS_OP_INTERRUPTIBLE : 0) 464 464 465 - #define fill_default_sys_attrs(sys_attr, type, mode) \ 465 + #define fill_default_sys_attrs(sys_attr, mode) \ 466 466 do { \ 467 467 sys_attr.owner = from_kuid(&init_user_ns, current_fsuid()); \ 468 468 sys_attr.group = from_kgid(&init_user_ns, current_fsgid()); \